From: Felix Schnizlein <fschnizlein@suse•com>
To: Thomas Gleixner <tglx@linutronix•de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Randy Dunlap <rdunlap@infradead•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
X86 ML <x86@kernel•org>, Borislav Petkov <bp@alien8•de>
Subject: Re: linux-next: Tree for Sep 19 (x86/kernel/cpuinfo.c)
Date: Tue, 26 Sep 2017 14:36:08 +0200 [thread overview]
Message-ID: <20170926123608.5azf7xqwobsnkc7b@angmar> (raw)
In-Reply-To: <alpine.DEB.2.20.1709261217480.1941@nanos>
[-- Attachment #1: Type: text/plain, Size: 2909 bytes --]
On 26.09.17, Thomas Gleixner wrote:
> On Tue, 26 Sep 2017, Greg Kroah-Hartman wrote:
> > On Tue, Sep 26, 2017 at 09:40:00AM +0200, Thomas Gleixner wrote:
> > > On Mon, 25 Sep 2017, Randy Dunlap wrote:
> > > > On 09/19/17 08:54, Randy Dunlap wrote:
> > > > > On 09/18/17 21:15, Stephen Rothwell wrote:
> > > > >> Hi all,
> > > > >>
> > > > >> Changes since 20170918:
> > > > >>
> > > > >> Linus' tree still had its build failure for which I reverted a commit.
> > > > >>
> > > > >
> > > > > on i386:
> > > > >
> > > > > ../arch/x86/kernel/cpuinfo.c: In function 'cpuinfo_flags':
> > >
> > > Where does this file come from? Random driver code added to arch/x86? This
> > > was neither acked nor reviewed by any x86 maintainer and just slapped into
> > > arch/x86/kernel/ without spending a split second of brain to find the spot
> > > where it actually belongs. It's not rocket science to figure that out.
> >
> > It is arch specific, cpu specific to be specific :)
> >
> > Where would you have this file go instead?
>
> arch/x86/kernel/cpu/
>
> That's where all the CPU related stuff including the proc/cpuinfo code
> lives. It's not rocket science to figure that out.
Yes this is my fault. I will fix this.
>
> > And these patches were posted many times, Felix, you did cc: the arch
> > maintainers, right? I don't have access to my archives at the moment...
I send all my patches via:
git send-email --to linux-kernel@vger•kernel.org --cc x86@kernel•org --cc gregkh@linuxfoundation•org --cc trenn@suse•com v4*.patch
Did I miss something?
>
> I have the following mails related to this in my direct inbox archive,
> i.e. where I was CC'ed and exactly the same amount in my full LKML archive:
>
> http://lkml.kernel.org/r/20170614150410.GA15806@kroah.com
> http://lkml.kernel.org/r/20170802160420.GA18507@kroah.com
> http://lkml.kernel.org/r/20170802164621.43ckgv2vieudvifc@angmar
> http://lkml.kernel.org/r/20170802174725.GB2333@kroah.com
> http://lkml.kernel.org/r/59824864020000EE001C9890@smtp.nue.novell.com
> http://lkml.kernel.org/r/20170828152906.GA2810@kroah.com
> http://lkml.kernel.org/r/20170828153642.GA29792@kroah.com
> http://lkml.kernel.org/r/20170906134531.GB11779@kroah.com
>
> All of these mails were completely out of context, i.e. the stuff was never
> posted to LKML at all. I got them because you added x86@kernel•org when
> replying.
>
> And all what I could see from your replies was:
>
> > arch/Kconfig | 3 ++
> > drivers/base/Makefile | 1 +
> > drivers/base/cpuinfo.c | 48 ++++++++++++++++++++++
> > include/linux/cpuhotplug.h | 1 +
> > include/linux/cpuinfo.h | 43 +++++++++++++++++++
>
> which I blissfully ignored.
>
> Thanks,
>
> tglx
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-09-26 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 4:15 linux-next: Tree for Sep 19 Stephen Rothwell
2017-09-19 15:49 ` linux-next: Tree for Sep 19 (drivers/gpu/drm/i915/i915_gem.c) Randy Dunlap
2017-09-19 15:54 ` linux-next: Tree for Sep 19 (x86/kernel/cpuinfo.c) Randy Dunlap
2017-09-26 1:19 ` Randy Dunlap
2017-09-26 7:40 ` Thomas Gleixner
2017-09-26 8:18 ` Greg Kroah-Hartman
2017-09-26 10:40 ` Thomas Gleixner
2017-09-26 12:36 ` Felix Schnizlein [this message]
2017-09-26 16:00 ` Thomas Gleixner
2017-09-26 21:18 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926123608.5azf7xqwobsnkc7b@angmar \
--to=fschnizlein@suse$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox