From: Will Deacon <will.deacon@arm•com>
To: Mark Brown <broonie@kernel•org>
Cc: linaro-kernel@lists•linaro.org,
kernel-build-reports@lists•linaro.org,
Catalin Marinas <catalin.marinas@arm•com>,
khilman@kernel•org, linux-next@vger•kernel.org,
matthew.hart@linaro•org, linux-arm-kernel@lists•infradead.org
Subject: Re: next-20180723 build: 2 failures 11 warnings (next-20180723)
Date: Tue, 24 Jul 2018 10:16:27 +0100 [thread overview]
Message-ID: <20180724091626.GC19324@arm.com> (raw)
In-Reply-To: <20180723181150.GF13981@sirena.org.uk>
On Mon, Jul 23, 2018 at 07:11:50PM +0100, Mark Brown wrote:
> On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote:
>
> Today's -next fails to build an arm64 allmodconfig with:
>
> > arm64-allmodconfig
> > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined!
>
> using
>
> aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412
>
> however it builds perfectly fine with
>
> aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016
>
> which honestly seems like a sensible and worthwhile upgrade at this
> point anyway given that it's a year and a half old so I'm going to do
> that for my builder (perhaps even jump on a newer version) but it seemed
> worth highlighting in case this is considered undesirable. A similar
> issue is hitting on KernelCI, we should probably look at upgrading the
> toolchain there too.
Hmm, it looks to me like this comes about because xen/privcmd.c is being
built as a module, but contains a call to set_pte_at() with a special pte:
pte_t pte = pte_mkspecial(pfn_pte(page_to_pfn(page), r->prot));
set_pte_at(r->mm, addr, ptep, pte);
which on arm64 contains:
if (pte_present(pte) && pte_user_exec(pte) && !pte_special(pte))
__sync_icache_dcache(pte);
so GCC 6 can optimise away the call to the non-exported symbol, but GCC 5
has trouble.
What I don't understand is why this suddenly cropped up. Did GCC 5 build
linux-next arm64 allmodconfig last week?
Cheers,
Will
next prev parent reply other threads:[~2018-07-24 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1fheAy-0003tU-Dq@optimist>
2018-07-23 18:11 ` next-20180723 build: 2 failures 11 warnings (next-20180723) Mark Brown
2018-07-24 9:16 ` Will Deacon [this message]
[not found] ` <CAH+k93GQRKO8s+0qkSH+d_2GkapMAp8C776Q4bZZnL37M5MBCw@mail.gmail.com>
2018-07-24 9:34 ` Matt Hart
2018-07-23 18:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724091626.GC19324@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=kernel-build-reports@lists$(echo .)linaro.org \
--cc=khilman@kernel$(echo .)org \
--cc=linaro-kernel@lists$(echo .)linaro.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=matthew.hart@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox