Subject: Re: linux-next: build failure after merge of the vfs tree

From: Stephen Rothwell <[email-masked]>
Date: Mon, 6 Aug 2018 22:24:01 +1000

Hi all,

On Mon, 6 Aug 2018 10:37:38 +1000 Stephen Rothwell <[email-masked]> wrote:
>
> After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> samples/statx/test-fsinfo.c:26:10: fatal error: linux/fsinfo.h: No such file or directory
>  #include <linux/fsinfo.h>
>           ^~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   90b413cb970a ("vfs: syscall: Add fsinfo() to query filesystem information")
> 
> I guess that headers_install (or whatever its called) has not bee run
> before the sample code is built.
> 
> I have applied the following patch for today:
> 
> From: Stephen Rothwell <[email-masked]>
> Date: Mon, 6 Aug 2018 10:29:34 +1000
> Subject: [PATCH] vfs: don;t build new sample programs yet
> 
> It seems that headers_install is not done before the samples
> are build so some needed include files are not in the right place.
> 
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  samples/statx/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/statx/Makefile b/samples/statx/Makefile
> index 05b4d30cdd3c..0b4d01822eca 100644
> --- a/samples/statx/Makefile
> +++ b/samples/statx/Makefile
> @@ -1,5 +1,5 @@
>  # List of programs to build
> -hostprogs-$(CONFIG_SAMPLE_STATX) := test-statx test-fsinfo test-fs-query
> +hostprogs-$(CONFIG_SAMPLE_STATX) := test-statx
>  
>  # Tell kbuild to always build the programs
>  always := $(hostprogs-y)

It turns out that commit

  ba5214f7f40c ("vfs: Implement parameter value retrieval with fsinfo()")

removed the "depends on BROKEN" from CONFIG_SAMPLE_STATX and that
breaks other builds (at least allyesconfig on s390).

-- 
Cheers,
Stephen Rothwell