public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Theodore Ts'o <tytso@mit•edu>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: linux-next: build failure after merge of the ext4 tree
Date: Tue, 9 Oct 2018 10:51:02 +1100	[thread overview]
Message-ID: <20181009105102.752dd9ee@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

Hi Ted,

After merging the ext4 tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/srcu.h:33,
                 from include/linux/notifier.h:16,
                 from include/linux/memory_hotplug.h:7,
                 from include/linux/mmzone.h:752,
                 from include/linux/gfp.h:6,
                 from include/linux/umh.h:4,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from fs/ext4/super.c:20:
fs/ext4/super.c: In function 'get_qf_name':
fs/ext4/super.c:931:40: error: 'struct ext4_sb_info' has no member named 's_qf_names'; did you mean 's_mb_maxs'?
  return rcu_dereference_protected(sbi->s_qf_names[type],
                                        ^~~~~~~~~~
include/linux/rcupdate.h:358:12: note: in definition of macro '__rcu_dereference_protected'
  ((typeof(*p) __force __kernel *)(p)); \
            ^
fs/ext4/super.c:931:9: note: in expansion of macro 'rcu_dereference_protected'
  return rcu_dereference_protected(sbi->s_qf_names[type],
         ^~~~~~~~~~~~~~~~~~~~~~~~~
fs/ext4/super.c:931:40: error: 'struct ext4_sb_info' has no member named 's_qf_names'; did you mean 's_mb_maxs'?
  return rcu_dereference_protected(sbi->s_qf_names[type],
                                        ^~~~~~~~~~
include/linux/rcupdate.h:358:35: note: in definition of macro '__rcu_dereference_protected'
  ((typeof(*p) __force __kernel *)(p)); \
                                   ^
fs/ext4/super.c:931:9: note: in expansion of macro 'rcu_dereference_protected'
  return rcu_dereference_protected(sbi->s_qf_names[type],
         ^~~~~~~~~~~~~~~~~~~~~~~~~
fs/ext4/super.c: In function 'parse_options':
fs/ext4/super.c:1976:26: warning: unused variable 'grp_qf_name' [-Wunused-variable]
  char *p, *usr_qf_name, *grp_qf_name;
                          ^~~~~~~~~~~
fs/ext4/super.c:1976:12: warning: unused variable 'usr_qf_name' [-Wunused-variable]
  char *p, *usr_qf_name, *grp_qf_name;
            ^~~~~~~~~~~

Caused by commit

  cc1ee227e890 ("ext4: fix use-after-free race in ext4_remount()'s error path")

# CONFIG_QUOTA is not set

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2018-10-08 23:51 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 23:51 Stephen Rothwell [this message]
2018-10-09  5:23 ` linux-next: build failure after merge of the ext4 tree Theodore Y. Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2026-05-29 11:59 Mark Brown
2026-06-01 12:43 ` Mark Brown
2026-06-01 15:17   ` Guan-Chun Wu
2025-07-14 22:22 Stephen Rothwell
2025-07-15  3:31 ` Zhang Yi
2025-02-13 22:58 Stephen Rothwell
2016-02-07 23:50 Stephen Rothwell
2016-01-03 23:34 Stephen Rothwell
2016-01-04 13:49 ` Theodore Ts'o
2015-07-23  0:56 Stephen Rothwell
2015-07-23 16:49 ` Theodore Ts'o
2015-07-23 17:23   ` Theodore Ts'o
2015-07-23 17:41     ` Tejun Heo
2015-05-07  1:14 Stephen Rothwell
2013-07-29  1:08 Stephen Rothwell
2013-07-31  1:27 ` Stephen Rothwell
2013-08-07  5:16 ` Sedat Dilek
2013-08-07  5:38   ` Stephen Rothwell
2013-08-07  5:43     ` Sedat Dilek
2013-08-07  5:59       ` Stephen Rothwell
2013-08-07 15:28     ` Kevin Hilman
2013-08-08  0:22       ` Stephen Rothwell
2013-08-08  0:36         ` Stephen Rothwell
2013-08-08 19:16           ` Yann E. MORIN
2013-08-08 21:54             ` Yann E. MORIN
2013-08-08 23:58               ` Stephen Rothwell
2013-08-09 11:42               ` Sam Ravnborg
2013-08-11 21:39                 ` Yann E. MORIN
2013-08-16 13:10                   ` Michal Marek
2013-08-16 17:14                     ` Sam Ravnborg
2013-08-16 18:02                       ` Yann E. MORIN
2013-04-03 23:43 Stephen Rothwell
2013-04-04 13:18 ` Lukáš Czerner
2013-04-04 13:20   ` Theodore Ts'o
2013-04-04 13:27     ` Lukáš Czerner
2012-07-10  1:23 Stephen Rothwell
2012-07-10  1:48 ` Aditya Kali
2012-01-03  0:35 Stephen Rothwell
2012-01-05 21:06 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009105102.752dd9ee@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=tytso@mit$(echo .)edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox