From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Max Filippov <jcmvbkbc@gmail•com>
Cc: Linux-Next <linux-next@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the xtensa tree
Date: Tue, 6 Nov 2018 10:19:41 +1100 [thread overview]
Message-ID: <20181106101941.458c46f8@canb.auug.org.au> (raw)
In-Reply-To: <CAMo8BfLfkk864aRwy0jG9Tq5CizyDax85Sq6+5=3N0wrA_Cg5w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Hi Max,
On Mon, 5 Nov 2018 15:14:44 -0800 Max Filippov <jcmvbkbc@gmail•com> wrote:
>
> On Mon, Nov 5, 2018 at 3:09 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > Commit
> >
> > 12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")
> >
> > is missing a Signed-off-by from its author and committer.
> >
> > Reverts are commits too.
>
> Thanks for catching that. Should I rewrite that branch fixing up that commit?
There is nothing else you can do. The only reason not to is if you
strictly do not rebase your branch (or there has been lots of other
activity - which there is not in this case).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-11-05 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 23:08 linux-next: Signed-off-by missing for commit in the xtensa tree Stephen Rothwell
2018-11-05 23:14 ` Max Filippov
2018-11-05 23:19 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106101941.458c46f8@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox