From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Kees Cook <keescook@google•com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor•com>,
smfrench@gmail•com, sprabhu@redhat•com,
linux-cifs@vger•kernel.org,
Linux-Next <linux-next@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: build warnings after merge of the cifs tree
Date: Mon, 26 Nov 2018 17:51:35 +1100 [thread overview]
Message-ID: <20181126175135.0565aac5@canb.auug.org.au> (raw)
In-Reply-To: <CAGXu5jJDbUZBmbx1ODS72WJKfcv20aMZczq=k4p4OhG8SV0roQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
Hi Kees,
On Sun, 25 Nov 2018 21:48:10 -0800 Kees Cook <keescook@google•com> wrote:
>
> On Sun, Nov 25, 2018 at 4:52 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > On Sun, 25 Nov 2018 18:31:40 -0600 Steve French <smfrench@gmail•com> wrote:
> > >
> > > Both of those cases are intentional fallthroughs and there are
> > > existing comments in the code noting the reasons for them to
> > > fallthrough
> > >
> > > (also can see the reasoning for these in the commits which introduced
> > > them from Sachin c369c9a4a7c82) and dde2356c84662)
> >
> > I am not questioning that :-)
> >
> > The gcc warning can be turned off by adding a /* fall through */
> > comment at the point the fall through happens. Kees and others are
> > working on the several hundred other places that need annotating.
>
> Right. The goal is to avoid adding any _new_ cases of this. :)
>
> > This one just popped up.
>
> It's already working! :) Thanks Stephen!
Actually this one was the product of how I filter out warnings ... it
was an old one, but the line numbers changed. I have now started
ignoring these if just the line numbers change.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-11-26 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 0:14 linux-next: build warnings after merge of the cifs tree Stephen Rothwell
2018-11-26 0:31 ` Steve French
2018-11-26 0:52 ` Stephen Rothwell
2018-11-26 5:48 ` Kees Cook
2018-11-26 6:51 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126175135.0565aac5@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=gustavo@embeddedor$(echo .)com \
--cc=keescook@google$(echo .)com \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=smfrench@gmail$(echo .)com \
--cc=sprabhu@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox