From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Philipp Zabel <p.zabel@pengutronix•de>,
Olof Johansson <olof@lixom•net>, Arnd Bergmann <arnd@arndb•de>,
ARM <linux-arm-kernel@lists•infradead.org>
Cc: "Linux Next Mailing List" <linux-next@vger•kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Clément Péron" <peron.clem@gmail•com>,
"Dinh Nguyen" <dinguyen@kernel•org>
Subject: linux-next: manual merge of the reset tree with the arm-soc tree
Date: Mon, 3 Dec 2018 09:26:26 +1100 [thread overview]
Message-ID: <20181203092626.7f1ab2f5@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
Hi Philipp,
Today's linux-next merge of the reset tree got a conflict in:
arch/arm/mach-socfpga/socfpga.c
between commit:
8f6f8c77fc4d ("reset: socfpga: add an early reset driver for SoCFPGA")
from the arm-soc tree and commit:
48e2bab90d8e ("ARM: socfpga: Clean unused functions")
from the reset tree.
Note that it is generally a bad idea to declare extern functions in c
files ... the declaration should be in some header file that is included
by the files containing the definition and usage. That would
have also removed the need for the forward declaration in
drivers/reset/reset-socfpga.c.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc arch/arm/mach-socfpga/socfpga.c
index 5fb6f79059a8,cc64576c102b..000000000000
--- a/arch/arm/mach-socfpga/socfpga.c
+++ b/arch/arm/mach-socfpga/socfpga.c
@@@ -32,7 -32,9 +32,9 @@@ void __iomem *rst_manager_base_addr
void __iomem *sdr_ctl_base_addr;
unsigned long socfpga_cpu1start_addr;
+ extern void __init socfpga_reset_init(void);
+
-void __init socfpga_sysmgr_init(void)
+static void __init socfpga_sysmgr_init(void)
{
struct device_node *np;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-12-02 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 22:26 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-24 21:28 linux-next: manual merge of the reset tree with the arm-soc tree Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203092626.7f1ab2f5@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=arnd@arndb$(echo .)de \
--cc=dinguyen@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=olof@lixom$(echo .)net \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=peron.clem@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox