Subject: linux-next: build warning after merge of the scsi-mkp tree

From: Stephen Rothwell <[email-masked]>
Date: Thu, 20 Dec 2018 17:34:57 +1100

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_build_raid_path_request':
drivers/scsi/smartpqi/smartpqi_init.c:478:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
   cdb_length = 0;
   ~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:479:2: note: here
  case BMIC_IDENTIFY_CONTROLLER:
  ^~~~
drivers/scsi/smartpqi/smartpqi_init.c:487:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
   cdb_length = 0;
   ~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:488:2: note: here
  case BMIC_WRITE_HOST_WELLNESS:
  ^~~~

Introduced by commit

  171c28653a2d ("scsi: smartpqi: turn off lun data caching for ptraid")

This due to my use of -Wimplicit-fallthrough for Kees Cook.  This is
new code.  The warning can be suppressed by adding a comment like

  /* fall through */

just above the following "case" or "default" to indicate that the
fallthrough is intended.

-- 
Cheers,
Stephen Rothwell