From: Stephen Rothwell <sfr@canb•auug.org.au>
To: "Rafael J. Wysocki" <rjw@rjwysocki•net>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Sinan Kaya <okaya@kernel•org>,
Paul Gortmaker <paul.gortmaker@windriver•com>
Subject: Re: linux-next: Fixes tags need some work in the pm tree
Date: Wed, 16 Jan 2019 09:43:05 +1100 [thread overview]
Message-ID: <20190116094305.0f66356a@canb.auug.org.au> (raw)
In-Reply-To: <2774660.l3LIlnjlhl@aspire.rjw.lan>
[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]
Hi Rafael,
On Tue, 15 Jan 2019 23:13:16 +0100 "Rafael J. Wysocki" <rjw@rjwysocki•net> wrote:
>
> On Tuesday, January 15, 2019 9:55:40 PM CET Stephen Rothwell wrote:
> > [I am experimenting with checking the Fixes tags in commits in linux-next.
> > Please let me know if you think I am being too strict.]
> >
> > Hi Rafael,
> >
> > Commits
> >
> > 62b33d57c534 ("drivers: thermal: int340x_thermal: Make PCI dependency explicit")
> > cd793ab22a93 ("x86/intel/lpss: Make PCI dependency explicit")
> > 42ac19e7b81e ("ACPI: EC: Look for ECDT EC after calling acpi_load_tables()")
> > 6c29b81b5695 ("platform/x86: apple-gmux: Make PCI dependency explicit")
> > 34783dc0182a ("platform/x86: intel_pmc: Make PCI dependency explicit")
> > 704658d1d3ae ("platform/x86: intel_ips: make PCI dependency explicit")
> > 5df37f3a1aa9 ("vga-switcheroo: make PCI dependency explicit")
> > da1df6ee4296 ("ata: pata_acpi: Make PCI dependency explicit")
> > ce97a22a596b ("ACPI / LPSS: Make PCI dependency explicit")
> >
> > Have malformed Fixes tags:
> >
> > There should be double quotes around the commit subject.
>
> Well, where does this requirement come from?
>
> It hasn't been there before AFAICS.
Documentation/process/submitting-patches.rst has the following, but I
am sure people are happy to discuss changes and it does say "For
example", so maybe I am being to strict? The counter argument is that
there are various (semi-)automated processes that use these tags and
being consistent probably makes those processes (and life for those who
run them) easier.
------------------------------------------------------------------------
If your patch fixes a bug in a specific commit, e.g. you found an issue using
``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
the SHA-1 ID, and the one line summary. For example::
Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
The following ``git config`` settings can be used to add a pretty format for
outputting the above style in the ``git log`` or ``git show`` commands::
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
------------------------------------------------------------------------
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-15 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 20:55 linux-next: Fixes tags need some work in the pm tree Stephen Rothwell
2019-01-15 21:10 ` Sinan Kaya
2019-01-15 22:44 ` Stephen Rothwell
2019-01-15 22:13 ` Rafael J. Wysocki
2019-01-15 22:43 ` Stephen Rothwell [this message]
2019-01-15 23:06 ` Rafael J. Wysocki
2019-01-15 23:43 ` Michael Ellerman
2019-01-16 11:34 ` Rafael J. Wysocki
2019-01-16 0:22 ` Paul Gortmaker
2019-01-16 11:50 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116094305.0f66356a@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=okaya@kernel$(echo .)org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox