From: kbuild test robot <lkp@intel•com>
To: Takashi Iwai <tiwai@suse•de>
Cc: kbuild-all@01•org, Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Jaroslav Kysela <perex@perex•cz>
Subject: Re: [PATCH] ALSA: hda - Fix unused variable warning
Date: Tue, 22 Jan 2019 15:16:13 +0800 [thread overview]
Message-ID: <201901221515.GZXGkMAq%fengguang.wu@intel.com> (raw)
In-Reply-To: <s5h7eeyzavg.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 3623 bytes --]
Hi Takashi,
I love your patch! Yet something to improve:
[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.0-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-hda-Fix-unused-variable-warning/20190122-135307
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.2.0 make.cross ARCH=sh
All errors (new ones prefixed by >>):
In file included from include/linux/preempt.h:11,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from sound/pci//hda/hda_codec.c:24:
sound/pci//hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
>> sound/pci//hda/hda_codec.c:2929:22: error: 'pcm' undeclared (first use in this function)
list_for_each_entry(pcm, &codec->pcm_list_head, list)
^~~
include/linux/list.h:517:7: note: in definition of macro 'list_for_each_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^~~
sound/pci//hda/hda_codec.c:2929:22: note: each undeclared identifier is reported only once for each function it appears in
list_for_each_entry(pcm, &codec->pcm_list_head, list)
^~~
include/linux/list.h:517:7: note: in definition of macro 'list_for_each_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^~~
vim +/pcm +2929 sound/pci//hda/hda_codec.c
59ed1ead Takashi Iwai 2015-02-18 2922
cc72da7d Takashi Iwai 2015-02-19 2923 static int hda_codec_runtime_suspend(struct device *dev)
59ed1ead Takashi Iwai 2015-02-18 2924 {
59ed1ead Takashi Iwai 2015-02-18 2925 struct hda_codec *codec = dev_to_hda_codec(dev);
cc72da7d Takashi Iwai 2015-02-19 2926 unsigned int state;
59ed1ead Takashi Iwai 2015-02-18 2927
59ed1ead Takashi Iwai 2015-02-18 2928 cancel_delayed_work_sync(&codec->jackpoll_work);
bbbc7e85 Takashi Iwai 2015-02-27 @2929 list_for_each_entry(pcm, &codec->pcm_list_head, list)
bbbc7e85 Takashi Iwai 2015-02-27 2930 snd_pcm_suspend_all(pcm->pcm);
cc72da7d Takashi Iwai 2015-02-19 2931 state = hda_call_codec_suspend(codec);
57cb54e5 Takashi Iwai 2018-06-21 2932 if (codec->link_down_at_suspend ||
57cb54e5 Takashi Iwai 2018-06-21 2933 (codec_has_clkstop(codec) && codec_has_epss(codec) &&
57cb54e5 Takashi Iwai 2018-06-21 2934 (state & AC_PWRST_CLK_STOP_OK)))
7639a06c Takashi Iwai 2015-03-03 2935 snd_hdac_codec_link_down(&codec->core);
029d92c2 Takashi Iwai 2018-12-08 2936 codec_display_power(codec, false);
59ed1ead Takashi Iwai 2015-02-18 2937 return 0;
59ed1ead Takashi Iwai 2015-02-18 2938 }
59ed1ead Takashi Iwai 2015-02-18 2939
:::::: The code at line 2929 was first introduced by commit
:::::: bbbc7e8502c95237dbd86cc4d0a12ca9a6b18c8f ALSA: hda - Allocate hda_pcm objects dynamically
:::::: TO: Takashi Iwai <tiwai@suse•de>
:::::: CC: Takashi Iwai <tiwai@suse•de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51024 bytes --]
prev parent reply other threads:[~2019-01-22 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 0:21 linux-next: build warning after merge of the sound tree Stephen Rothwell
2019-01-21 8:13 ` Takashi Iwai
2019-01-22 7:16 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201901221515.GZXGkMAq%fengguang.wu@intel.com \
--to=lkp@intel$(echo .)com \
--cc=kbuild-all@01$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=perex@perex$(echo .)cz \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox