From: Liviu Dudau <liviu@dudau•co.uk>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Qian Cai <cai@lca•pw>, Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Fixes tags needs some work in the akpm-current tree
Date: Fri, 1 Feb 2019 00:18:26 +0000 [thread overview]
Message-ID: <20190201001825.GB3110@bart.dudau.co.uk> (raw)
In-Reply-To: <20190131145734.80036199beb369d3ceb0123a@linux-foundation.org>
On Thu, Jan 31, 2019 at 02:57:34PM -0800, Andrew Morton wrote:
> On Thu, 31 Jan 2019 22:51:52 +0000 Liviu Dudau <liviu@dudau•co.uk> wrote:
>
> > On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> > >
> > >
> > > On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > > > In commit
> > > >
> > > > 6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> > > >
> > > > Fixes tag
> > > >
> > > > Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> > > >
> > > > has these problem(s):
> > > >
> > > > - SHA1 should be at least 12 digits long
> > > > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > > or later) just making sure it is not set (or set to "auto").
> > > >
> > >
> > > I think it is better to replace with this version instead,
> > >
> > > https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> >
> >
> > That patch does not look related, afaict.
>
> Confused.
>
> https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> and
> https://lore.kernel.org/lkml/20181220203156.43441-1-cai@lca.pw/T/#u
>
> are very much related?
My bad, I've read the top of the message that was talking about my commit splitting the
Fixes: commit title into multiple lines and assumed that was the only issue reported.
>
> > Andrew, do you want me to re-send the patch with a fixed commit log, or are you OK to
> > do some inline editing?
>
> Resend what, exactly?
Content of commit 86c7502b25ed so that the title of the commit it fixes does not spill
over into the next line.
Best regards,
Liviu
--
________________________________________________________
________| |_______
\ | With enough courage, you can do without a reputation | /
\ | -- Rhett Butler | /
/ |________________________________________________________| \
/__________) (_________\
prev parent reply other threads:[~2019-02-01 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 0:05 linux-next: Fixes tags needs some work in the akpm-current tree Stephen Rothwell
2019-01-31 1:51 ` Qian Cai
2019-01-31 22:51 ` Liviu Dudau
2019-01-31 22:57 ` Andrew Morton
2019-02-01 0:18 ` Liviu Dudau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201001825.GB3110@bart.dudau.co.uk \
--to=liviu@dudau$(echo .)co.uk \
--cc=akpm@linux-foundation$(echo .)org \
--cc=cai@lca$(echo .)pw \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox