public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Doug Ledford <dledford@redhat•com>, Jason Gunthorpe <jgg@mellanox•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Kaike Wan <kaike.wan@intel•com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
	Kees Cook <keescook@chromium•org>
Subject: linux-next: build warning after merge of the rdma tree
Date: Thu, 14 Feb 2019 11:23:00 +1100	[thread overview]
Message-ID: <20190214112300.41c0c7bd@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/infiniband/hw/hfi1/tid_rdma.c: In function 'hfi1_tid_rdma_wqe_interlock':
drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   switch (prev->wr.opcode) {
   ^~~~~~
drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
  case IB_WR_RDMA_READ:
  ^~~~

Introduced by commit

  c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early.  The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-02-14  0:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  0:23 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-10 10:11 linux-next: build warning after merge of the rdma tree Stephen Rothwell
2021-02-10 13:47 ` Jason Gunthorpe
2021-02-10 17:17   ` Nathan Chancellor
2021-02-10 22:08   ` Lee Jones
2020-12-03  7:42 Stephen Rothwell
2020-12-03  9:39 ` Leon Romanovsky
2019-02-14  0:18 Stephen Rothwell
2019-02-14  0:21 ` Doug Ledford
2019-02-14 12:35   ` Wan, Kaike
2018-07-26  0:55 Stephen Rothwell
2018-07-26  3:05 ` Jason Gunthorpe
2018-07-26  5:10   ` Bart Van Assche
2018-07-26 17:38     ` Jason Gunthorpe
2018-07-10  1:28 Stephen Rothwell
2018-05-06 23:44 Stephen Rothwell
2018-05-14 18:03 ` Jason Gunthorpe
2018-05-14 18:09   ` Steve Wise
2018-05-14 20:29     ` Steve Wise
2018-05-06 23:40 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214112300.41c0c7bd@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=dledford@redhat$(echo .)com \
    --cc=gustavo@embeddedor$(echo .)com \
    --cc=jgg@mellanox$(echo .)com \
    --cc=kaike.wan@intel$(echo .)com \
    --cc=keescook@chromium$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox