public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Hugo Lefeuvre <hle@owl•eu.com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Arnd Bergmann <arnd@arndb•de>,
	Linux Next Mailing List <linux-next@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the asm-generic tree
Date: Tue, 19 Feb 2019 08:45:19 +0100	[thread overview]
Message-ID: <20190219074519.GA2294@behemoth.owl.eu.com.local> (raw)
In-Reply-To: <20190219173654.47e9bc36@canb.auug.org.au>

Hi Stephen, Arnd,

> After merging the asm-generic tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
> ...
> Caused by commit
> 
>   8e074c243ed3 ("iomap: add missing const to ioread*/iowrite addr arg")

I have prepared a patch addressing this issue, and am currently building it
with a powerpc cross compiler. I'll submit it once it's done. Please tell
me if I should update the initial patch instead.

> The const qualifiers are also missing in:
> 
> arch/parisc/lib/iomap.c
> arch/sh/kernel/iomap.c

I also have patches for these architectures, but it is more complicated for
me to test them with a cross compiler. Should I still submit them?

> I have reverted that commit for today.
> 
> BTW, that commit only added the const to the ioread* functions ...

Yes, and it does not even make sense to add a const qualifier to the addr
argument in the iowrite case. That was a bad commit message.

Thanks, and sorry for the trouble.

regards,
 Hugo

-- 
                Hugo Lefeuvre (hle)    |    www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C

  reply	other threads:[~2019-02-19  7:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19  6:36 linux-next: build failure after merge of the asm-generic tree Stephen Rothwell
2019-02-19  7:45 ` Hugo Lefeuvre [this message]
2019-02-19 10:14   ` Arnd Bergmann
2019-02-19 11:19     ` Hugo Lefeuvre
2019-02-19 14:42       ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2024-08-06  4:54 Stephen Rothwell
2024-08-06  6:30 ` Arnd Bergmann
2024-08-06  6:50   ` Stephen Rothwell
2022-07-20 12:36 Stephen Rothwell
2022-07-20 12:51 ` Arnd Bergmann
2022-07-21  6:57   ` Lukas Bulwahn
2018-03-15 22:13 Stephen Rothwell
2018-03-15 22:47 ` Bin Liu
2018-03-16  8:07   ` Arnd Bergmann
2015-10-14 22:55 Stephen Rothwell
2015-10-14 23:32 ` kbuild test robot
2015-10-15  2:37   ` Stephen Rothwell
2014-11-19  7:54 Stephen Rothwell
2014-11-19  9:21 ` Arnd Bergmann
2014-09-26 10:02 Stephen Rothwell
2014-09-26 10:53 ` Will Deacon
2014-09-26 11:14   ` Arnd Bergmann
2014-09-29 22:31     ` Stephen Rothwell
2014-09-30 10:00       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219074519.GA2294@behemoth.owl.eu.com.local \
    --to=hle@owl$(echo .)eu.com \
    --cc=arnd@arndb$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox