From: Michael Holzheu <holzheu@linux•ibm.com>
To: Mike Snitzer <snitzer@redhat•com>
Cc: Benjamin Block <bblock@linux•ibm.com>,
Carstens <heiko.carstens@de•ibm.com>,
Alexander Duyck <alexander.duyck@gmail•com>,
dm-devel@redhat•com, linux-next@vger•kernel.org,
Patocka <mpatocka@redhat•com>,
Mikulas, Heiko, Steffen Maier <maier@linux•ibm.com>
Subject: Re: bio-based DM's "noclone" changes have been dropped from 5.1 [was: Re: linux-next: Boot hangs 3 minutes with device mapper on s390]
Date: Thu, 7 Mar 2019 11:18:40 +0100 [thread overview]
Message-ID: <20190307111840.206f98ca@TP-holzheu> (raw)
In-Reply-To: <20190305222112.GA26427@redhat.com>
On Tue, 5 Mar 2019 17:21:12 -0500
Mike Snitzer <snitzer@redhat•com> wrote:
> On Tue, Mar 05 2019 at 1:02pm -0500,
> Alexander Duyck <alexander.duyck@gmail•com> wrote:
>
> > On Mon, Mar 4, 2019 at 8:03 PM Mike Snitzer <snitzer@redhat•com> wrote:
> > >
> > > Hi,
> > >
> > > Alexander reported this same boot hang in another thread. I was able to
> > > reproduce using an x86_64 .config that Alexander provided.
> > >
> > > I've pushed this fix out to linux-next:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.1&id=be2c5301817833f692aadb2e5fa209582db01d3b
> > >
> > > If you could verify this fix works for you I'd appreciate it.
> > >
> > > Thanks,
> > > Mike
> >
> > I've verified I am no longer seeing the issue with this patch applied.
>
> Thanks for testing.
>
> But so you and others are aware: based on further internal discussion
> with Mikulas, I decided to drop all the bio-based DM "noclone" changes
> that were developed for 5.1.
>
> Mikulas had a really good point that the 10-13% performance benefit seen
> with 512b IO workloads all but disappears to only a 1% improvement as
> soon as the bio's payload is increased to >= 4K. Meaning the risk
> associated with the noclone changes really is _not_ worth the reward.
>
> I've rebased the dm-5.1 branch accordingly and linux-next will pick it
> up tonight.
I can confirm that the problem disappeared now on s390.
Thanks!
Michael
next prev parent reply other threads:[~2019-03-07 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190301183350.5ff697d4@TP-holzheu>
2019-03-01 18:30 ` linux-next: Boot hangs 3 minutes with device mapper on s390 Mike Snitzer
2019-03-04 10:01 ` Steffen Maier
2019-03-04 10:03 ` Michael Holzheu
2019-03-05 4:03 ` Mike Snitzer
2019-03-05 9:46 ` Mikulas Patocka
2019-03-05 13:29 ` Mike Snitzer
2019-03-05 18:02 ` Alexander Duyck
2019-03-05 22:21 ` bio-based DM's "noclone" changes have been dropped from 5.1 [was: Re: linux-next: Boot hangs 3 minutes with device mapper on s390] Mike Snitzer
2019-03-07 10:18 ` Michael Holzheu [this message]
[not found] ` <alpine.LRH.2.02.1903011516160.20592@file01.intranet.prod.int.rdu2.redhat.com>
2019-03-01 20:30 ` linux-next: Boot hangs 3 minutes with device mapper on s390 Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307111840.206f98ca@TP-holzheu \
--to=holzheu@linux$(echo .)ibm.com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=bblock@linux$(echo .)ibm.com \
--cc=dm-devel@redhat$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maier@linux$(echo .)ibm.com \
--cc=mpatocka@redhat$(echo .)com \
--cc=snitzer@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox