Subject: Re: linux-next: Fixes tag needs some work in the hwmon-staging tree

From: Guenter Roeck <[email-masked]>
Date: Thu, 4 Apr 2019 14:26:18 -0700

On Fri, Apr 05, 2019 at 07:54:38AM +1100, Stephen Rothwell wrote:
> Hi Guenter,
> 
> In commit
> 
>   742ad88f0440 ("hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses")
> 
> Fixes tag
> 
>   Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)")
> 
The original subject is "[PATCH] I2C: Move hwmon drivers (2/3)", and
I consider it quite pointless to include the "[PATCH] " prefix.
Same for the other tag.

Guenter

> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 
> In commit
> 
>   4d730440042d ("hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses")
> 
> Fixes tag
> 
>   Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 
> In commit
> 
>   2f38d5d31508 ("hwmon: (f71805f) Use request_muxed_region for Super-IO accesses")
> 
> Fixes tag
> 
>   Fixes: e53004e20a58e ("hwmon: New f71805f driver")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 
> -- 
> Cheers,
> Stephen Rothwell