From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Deepak Singh Rawat <drawat@vmware•com>
Cc: "airlied@linux•ie" <airlied@linux•ie>,
Thomas Hellstrom <thellstrom@vmware•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"dri-devel@lists•freedesktop.org"
<dri-devel@lists•freedesktop.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the drm tree
Date: Wed, 24 Apr 2019 11:12:59 +1000 [thread overview]
Message-ID: <20190424111259.6a1aacce@canb.auug.org.au> (raw)
In-Reply-To: <44707352378dcd414b476ec5420db23093fb9351.camel@vmware.com>
[-- Attachment #1.1: Type: text/plain, Size: 916 bytes --]
Hi Deepak,
On Wed, 24 Apr 2019 00:36:19 +0000 Deepak Singh Rawat <drawat@vmware•com> wrote:
>
> On Wed, 2019-04-24 at 10:22 +1000, Stephen Rothwell wrote:
> >
> > Commit
> >
> > a9f58c456e9d ("drm/vmwgfx: Be more restrictive when dirtying
> > resources")
>
> Actully the Signed-off-by: is not missing see
>
> https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/vmwgfx?id=a9f58c456e9dde6f272e7be4d6bed607fd7008aa
There is no Signed-off-by from you as the committer (just a
Reviewed-by from you and a Signed-off-by from the author).
> By the way there is the patter "---" before Signed-off-by:(which is
> same as used by patch to separate description from code) and I think
> the script is reading only till that point. I think "---" should not be
> used in patch description.
All the tags should be *before* the "-- " or "---" separator.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists•freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-24 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 0:22 linux-next: Signed-off-by missing for commit in the drm tree Stephen Rothwell
2019-04-24 0:36 ` Deepak Singh Rawat
2019-04-24 1:12 ` Stephen Rothwell [this message]
2019-04-24 1:31 ` Deepak Singh Rawat
2019-04-24 1:59 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2019-11-15 23:21 Stephen Rothwell
2019-08-23 9:51 Stephen Rothwell
2019-02-20 0:51 Stephen Rothwell
2018-09-21 0:21 Stephen Rothwell
2018-03-09 4:44 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424111259.6a1aacce@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=airlied@linux$(echo .)ie \
--cc=drawat@vmware$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=thellstrom@vmware$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox