Subject: Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia)

From: Pavel Machek <[email-masked]>
Date: Mon, 29 Apr 2019 17:32:00 +0200

On Mon 2019-04-29 08:03:02, Randy Dunlap wrote:
> On 4/29/19 2:03 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20190426:
> > 
> 
> on i386:
> 
> when CONFIG_LEDS_TURRIS_OMNIA=y and CONFIG_I2C=m:
> 
> Probably should also depend on I2C.
> 
> 
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_remove':
> leds-turris-omnia.c:(.text+0xb): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_led_brightness_set_blocking':
> leds-turris-omnia.c:(.text+0x62): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_probe':
> leds-turris-omnia.c:(.text+0x1d8): undefined reference to `i2c_smbus_write_byte_data'
> ld: leds-turris-omnia.c:(.text+0x1f6): undefined reference to `i2c_smbus_write_byte_data'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_driver_init':
> leds-turris-omnia.c:(.init.text+0x8): undefined reference to `i2c_register_driver'
> ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_driver_exit':
> leds-turris-omnia.c:(.exit.text+0x6): undefined reference to `i2c_del_driver'

Ack.

It can also depend on ARM or even specific ARM soc... unless we are
compile testing. This is for specific router...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html