From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Matteo Croce <mcroce@redhat•com>
Cc: Randy Dunlap <rdunlap@infradead•org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Luis Chamberlain <mcgrof@kernel•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-kernel@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH] firmware_loader: fix build without sysctl
Date: Fri, 31 May 2019 11:37:21 +1000 [thread overview]
Message-ID: <20190531113721.5057ce05@canb.auug.org.au> (raw)
In-Reply-To: <20190531012649.31797-1-mcroce@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
Hi all,
On Fri, 31 May 2019 03:26:49 +0200 Matteo Croce <mcroce@redhat•com> wrote:
>
> firmware_config_table has references to the sysctl code which
> triggers a build failure when CONFIG_PROC_SYSCTL is not set:
>
> ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x30): undefined reference to `sysctl_vals'
> ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x38): undefined reference to `sysctl_vals'
> ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x70): undefined reference to `sysctl_vals'
> ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x78): undefined reference to `sysctl_vals'
>
> Put the firmware_config_table struct under #ifdef CONFIG_PROC_SYSCTL.
>
> Fixes: 6a33853c5773 ("proc/sysctl: add shared variables for range check")
> Reported-by: Randy Dunlap <rdunlap@infradead•org>
> Signed-off-by: Matteo Croce <mcroce@redhat•com>
I have added this to linux-next today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-31 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 1:26 [PATCH] firmware_loader: fix build without sysctl Matteo Croce
2019-05-31 1:32 ` Stephen Rothwell
2019-05-31 1:37 ` Stephen Rothwell [this message]
2019-05-31 2:15 ` Randy Dunlap
2019-05-31 9:12 ` Matteo Croce
2019-06-01 2:14 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531113721.5057ce05@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mcgrof@kernel$(echo .)org \
--cc=mcroce@redhat$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox