From: Sebastian Reichel <sre@kernel•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Nick Crews <ncrews@chromium•org>,
Enric Balletbo i Serra <enric.balletbo@collabora•com>
Subject: Re: linux-next: build failure after merge of the battery tree
Date: Fri, 28 Jun 2019 17:31:46 +0200 [thread overview]
Message-ID: <20190628153146.c2lh4y55qvcmqhry@earth.universe> (raw)
In-Reply-To: <20190628140304.76caf572@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
Hi,
On Fri, Jun 28, 2019 at 02:03:04PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/power/supply/wilco-charger.c: In function 'wilco_charge_get_property':
> drivers/power/supply/wilco-charger.c:104:8: error: implicit declaration of function 'wilco_ec_get_byte_property'; did you mean 'wilco_charge_get_property'? [-Werror=implicit-function-declaration]
> ret = wilco_ec_get_byte_property(ec, property_id, &raw);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> wilco_charge_get_property
> drivers/power/supply/wilco-charger.c: In function 'wilco_charge_set_property':
> drivers/power/supply/wilco-charger.c:130:10: error: implicit declaration of function 'wilco_ec_set_byte_property'; did you mean 'wilco_charge_set_property'? [-Werror=implicit-function-declaration]
> return wilco_ec_set_byte_property(ec, PID_CHARGE_MODE, mode);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> wilco_charge_set_property
>
> Caused by commit
>
> 0736343e4c56 ("power_supply: wilco_ec: Add charging config driver")
>
> I have reverted that commit for today.
Oops, thanks for the hint. I did not notice this with ARM
allmodconfig. I dropped the patch for this cycle.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-28 15:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 4:03 linux-next: build failure after merge of the battery tree Stephen Rothwell
2019-06-28 15:31 ` Sebastian Reichel [this message]
2019-06-28 16:56 ` Enric Balletbo i Serra
2019-06-29 0:33 ` Stephen Rothwell
2019-07-01 13:22 ` Enric Balletbo i Serra
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 13:54 Mark Brown
2026-03-03 23:02 ` Sebastian Reichel
2023-08-21 2:57 Stephen Rothwell
2023-08-21 7:07 ` Lee Jones
2023-08-21 7:13 ` Lee Jones
2023-08-21 12:41 ` Rob Herring
2023-08-21 12:46 ` Lee Jones
2022-06-20 0:45 Stephen Rothwell
2022-06-21 12:30 ` Asmaa Mnebhi
2022-06-24 2:47 ` Stephen Rothwell
2022-06-24 12:44 ` Asmaa Mnebhi
2022-06-28 2:30 ` Stephen Rothwell
2022-05-04 2:35 Stephen Rothwell
2019-12-19 0:01 Stephen Rothwell
2019-12-19 1:35 ` Sebastian Reichel
2015-09-29 1:45 Stephen Rothwell
2015-10-02 1:49 ` Stephen Rothwell
2015-10-08 1:04 ` Stephen Rothwell
2015-10-08 6:12 ` Belisko Marek
2015-10-08 10:21 ` Stephen Rothwell
2015-10-15 14:26 ` Stephen Rothwell
2015-10-20 22:32 ` Stephen Rothwell
2015-10-21 6:12 ` Belisko Marek
2015-07-27 1:40 Stephen Rothwell
2012-07-16 4:09 Stephen Rothwell
2012-07-16 4:57 ` Chanwoo Choi
2012-03-15 2:56 Stephen Rothwell
2012-03-20 4:39 ` Stephen Rothwell
2012-03-26 2:13 ` Stephen Rothwell
2012-03-26 16:11 ` Anton Vorontsov
2012-03-26 21:44 ` Stephen Rothwell
2012-03-26 21:47 ` Stephen Rothwell
2012-03-27 13:03 ` Anton Vorontsov
2012-03-28 11:38 ` Mark Brown
[not found] <C3AE124F08223B42BC95AEB82F0F6CED1FDB2C78@KCHJEXMB02.kpit.com>
2012-01-09 8:29 ` Ashish Jangam
2012-01-09 13:10 ` linux-next: " Anton Vorontsov
2012-01-09 23:53 ` Mark Brown
2012-01-10 0:51 ` Anton Vorontsov
2012-01-09 2:11 Stephen Rothwell
2012-01-05 3:40 Stephen Rothwell
2012-01-05 15:25 ` Anton Vorontsov
2012-01-05 15:53 ` Greg KH
2012-01-07 9:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628153146.c2lh4y55qvcmqhry@earth.universe \
--to=sre@kernel$(echo .)org \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=ncrews@chromium$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox