Subject: Re: linux-next: Tree for Jul 18 (header build error)

From: Stephen Rothwell <[email-masked]>
Date: Fri, 19 Jul 2019 10:36:05 +1000

Hi all,

On Fri, 19 Jul 2019 10:05:57 +1000 Stephen Rothwell <[email-masked]> wrote:
>
> On Thu, 18 Jul 2019 10:00:22 -0700 Randy Dunlap <[email-masked]> wrote:
> >
> > on x86_64, when CONFIG_BLOCK is not set:
> > 
> >   CC      include/linux/iomap.h.s
> > In file included from <command-line>:0:0:
> > ./../include/linux/iomap.h: In function ‘iomap_sector’:
> > ./../include/linux/iomap.h:76:48: error: ‘SECTOR_SHIFT’ undeclared (first use in this function); did you mean ‘SECTIONS_SHIFT’?
> >   return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
> >                                                 ^~~~~~~~~~~~  
> 
> include/linux/iomap.h should only be used when CONFIG_BLOCK is set (if
> you follow the Kconfig trail).  So maybe this header should only be
> compile tested if CONFIG_BLOCK is set.

Or maybe fs/iomap/ needs to grow a private header file for stuff like
iomap_sector() ?

-- 
Cheers,
Stephen Rothwell