From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Mimi Zohar <zohar@linux•vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Thiago Jung Bauermann <bauerman@linux•ibm.com>,
Philipp Rudo <prudo@linux•ibm.com>, Jessica Yu <jeyu@kernel•org>
Subject: linux-next: build failure after merge of the integrity tree
Date: Tue, 6 Aug 2019 12:15:19 +1000 [thread overview]
Message-ID: <20190806121519.0f8ac653@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2650 bytes --]
Hi all,
After merging the integrity tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from <command-line>:
include/linux/module_signature.h:32:2: error: unknown type name 'u8'
u8 algo; /* Public-key crypto algorithm [0] */
^~
include/linux/module_signature.h:33:2: error: unknown type name 'u8'
u8 hash; /* Digest algorithm [0] */
^~
include/linux/module_signature.h:34:2: error: unknown type name 'u8'
u8 id_type; /* Key identifier type [PKEY_ID_PKCS7] */
^~
include/linux/module_signature.h:35:2: error: unknown type name 'u8'
u8 signer_len; /* Length of signer's name [0] */
^~
include/linux/module_signature.h:36:2: error: unknown type name 'u8'
u8 key_id_len; /* Length of key identifier [0] */
^~
include/linux/module_signature.h:37:2: error: unknown type name 'u8'
u8 __pad[3];
^~
include/linux/module_signature.h:38:2: error: unknown type name '__be32'
__be32 sig_len; /* Length of signature data */
^~~~~~
include/linux/module_signature.h:41:54: error: unknown type name 'size_t'
int mod_check_sig(const struct module_signature *ms, size_t file_len,
^~~~~~
include/linux/module_signature.h:41:54: note: 'size_t' is defined in header '<stddef.h>'; did you forget to '#include <stddef.h>'?
include/linux/module_signature.h:1:1:
+#include <stddef.h>
/* SPDX-License-Identifier: GPL-2.0+ */
include/linux/module_signature.h:41:54:
int mod_check_sig(const struct module_signature *ms, size_t file_len,
^~~~~~
Caused by commit
c8424e776b09 ("MODSIGN: Export module signature definitions")
We now have build time checks to make sure that include files are self
contained.
I have added the following fix patch for today.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 6 Aug 2019 12:09:36 +1000
Subject: [PATCH] MODSIGN: make new include file self contained
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
include/linux/module_signature.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/module_signature.h b/include/linux/module_signature.h
index 523617fc5b6a..7eb4b00381ac 100644
--- a/include/linux/module_signature.h
+++ b/include/linux/module_signature.h
@@ -9,6 +9,8 @@
#ifndef _LINUX_MODULE_SIGNATURE_H
#define _LINUX_MODULE_SIGNATURE_H
+#include <linux/types.h>
+
/* In stripped ARM and x86-64 modules, ~ is surprisingly rare. */
#define MODULE_SIG_STRING "~Module signature appended~\n"
--
2.20.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-08-06 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 2:15 Stephen Rothwell [this message]
2019-08-06 3:18 ` linux-next: build failure after merge of the integrity tree Thiago Jung Bauermann
2019-08-06 3:45 ` Stephen Rothwell
2019-08-06 19:02 ` Mimi Zohar
-- strict thread matches above, loose matches on Subject: below --
2023-02-07 0:51 Stephen Rothwell
2023-02-07 12:48 ` Roberto Sassu
2019-06-14 5:34 Stephen Rothwell
2019-06-14 14:09 ` Mimi Zohar
2018-07-17 4:40 Stephen Rothwell
2018-07-17 13:18 ` Mimi Zohar
2018-07-17 22:21 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806121519.0f8ac653@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=dmitry.kasatkin@gmail$(echo .)com \
--cc=jeyu@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=prudo@linux$(echo .)ibm.com \
--cc=zohar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox