From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Peter Collingbourne <pcc@google•com>
Cc: Will Deacon <will@kernel•org>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>
Subject: Re: linux-next: build failure after merge of the arm64 tree
Date: Thu, 8 Aug 2019 09:43:46 +1000 [thread overview]
Message-ID: <20190808094346.31383383@canb.auug.org.au> (raw)
In-Reply-To: <CAMn1gO65tjqHgWsX_gTB9eaerFRevWtWd6dkkEoHnjo+BG1m=w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]
Hi all,
On Wed, 7 Aug 2019 09:33:07 -0700 Peter Collingbourne <pcc@google•com> wrote:
>
> On Wed, Aug 7, 2019 at 8:25 AM Will Deacon <will@kernel•org> wrote:
> >
> > From 71c67a31f09fa8fdd1495dffd96a5f0d4cef2ede Mon Sep 17 00:00:00 2001
> > From: Will Deacon <will@kernel•org>
> > Date: Wed, 7 Aug 2019 12:48:33 +0100
> > Subject: [PATCH] init/Kconfig: Fix infinite Kconfig recursion on PPC
> >
> > Commit 5cf896fb6be3 ("arm64: Add support for relocating the kernel with
> > RELR relocations") introduced CONFIG_TOOLS_SUPPORT_RELR, which checks
> > for RELR support in the toolchain as part of the kernel configuration.
> > During this procedure, "$(NM)" is invoked to see if it supports the new
> > relocation format, however PowerPC conditionally overrides this variable
> > in the architecture Makefile in order to pass '--synthetic' when
> > targetting PPC64.
> >
> > This conditional override causes Kconfig to recurse forever, since
> > CONFIG_TOOLS_SUPPORT_RELR cannot be determined without $(NM) being
> > defined, but that in turn depends on CONFIG_PPC64:
> >
> > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu-
> > scripts/kconfig/conf --syncconfig Kconfig
> > scripts/kconfig/conf --syncconfig Kconfig
> > scripts/kconfig/conf --syncconfig Kconfig
> > [...]
> >
> > In this particular case, it looks like PowerPC may be able to pass
> > '--synthetic' unconditionally to nm or even drop it altogether. While
> > that is being resolved, let's just bodge the RELR check by picking up
> > $(NM) directly from the environment in whatever state it happens to be
> > in.
> >
> > Cc: Peter Collingbourne <pcc@google•com>
> > Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext•com>
> > Signed-off-by: Will Deacon <will@kernel•org>
>
> Tested-by: Peter Collingbourne <pcc@google•com>
> Reviewed-by: Peter Collingbourne <pcc@google•com>
Thanks for sorting this out (even temporarily).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-07 23:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 23:50 linux-next: build failure after merge of the arm64 tree Stephen Rothwell
2019-08-07 2:34 ` Peter Collingbourne
2019-08-07 11:46 ` Will Deacon
2019-08-07 14:43 ` Masahiro Yamada
2019-08-07 15:25 ` Will Deacon
2019-08-07 16:33 ` Peter Collingbourne
2019-08-07 23:43 ` Stephen Rothwell [this message]
2019-08-16 4:52 ` Michael Ellerman
2019-08-16 17:27 ` Will Deacon
2019-08-20 7:27 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2022-11-21 23:41 Stephen Rothwell
2022-11-22 4:17 ` Jiucheng Xu
2022-11-22 4:52 ` Stephen Rothwell
2022-11-15 22:04 Stephen Rothwell
2022-11-15 23:52 ` Besar Wicaksono
2022-11-16 10:49 ` Suzuki K Poulose
2015-03-27 0:15 Stephen Rothwell
2012-09-17 1:24 Stephen Rothwell
2012-09-17 8:41 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808094346.31383383@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=pcc@google$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox