Subject: linux-next: build failure after merge of the gpio tree

From: Stephen Rothwell <[email-masked]>
Date: Fri, 16 Aug 2019 21:38:12 +1000

Hi all,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

In file included from include/asm-generic/gpio.h:13,
                 from include/linux/gpio.h:62,
                 from include/linux/of_gpio.h:16,
                 from arch/powerpc/platforms/44x/warp.c:14:
include/linux/gpio/driver.h:546:13: error: 'gpiochip_populate_parent_fwspec_fourcell' defined but not used [-Werror=unused-function]
 static void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/gpio/driver.h:539:13: error: 'gpiochip_populate_parent_fwspec_twocell' defined but not used [-Werror=unused-function]
 static void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and several more similar ...

Caused by commit

  fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")

I have applied the following patch for today:

From: Stephen Rothwell <[email-masked]>
Date: Fri, 16 Aug 2019 21:29:30 +1000
Subject: [PATCH] gpio: stubs in headers should be inline

Fixes: fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")
Signed-off-by: Stephen Rothwell <[email-masked]>
---
 include/linux/gpio/driver.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index f285fee898f6..13c7d7ff497d 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -536,14 +536,14 @@ void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 
 #else
 
-static void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
+static inline void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
 						    struct irq_fwspec *fwspec,
 						    unsigned int parent_hwirq,
 						    unsigned int parent_type)
 {
 }
 
-static void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
+static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 						     struct irq_fwspec *fwspec,
 						     unsigned int parent_hwirq,
 						     unsigned int parent_type)
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell