From: Stephen Rothwell <sfr@canb•auug.org.au>
To: James Morris <jmorris@namei•org>
Cc: Kees Cook <keescook@chromium•org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Matthew Garrett <mjg59@google•com>,
Casey Schaufler <casey@schaufler-ca•com>
Subject: Re: linux-next: build failure after merge of the security tree
Date: Mon, 19 Aug 2019 13:21:19 +1000 [thread overview]
Message-ID: <20190819132119.7349e881@canb.auug.org.au> (raw)
In-Reply-To: <201908121033.BFBE9516AC@keescook>
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
Hi all,
On Mon, 12 Aug 2019 10:34:17 -0700 Kees Cook <keescook@chromium•org> wrote:
>
> On Mon, Aug 12, 2019 at 02:58:23PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the security tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like below.
> >
> > Caused by commit
> >
> > 45d29f9e9b8b ("security: Support early LSMs")
> >
> > I have added the following fix for today:
> >
> > From: Stephen Rothwell <sfr@canb•auug.org.au>
> > Date: Mon, 12 Aug 2019 14:54:20 +1000
> > Subject: [PATCH] early_security_init() needs a stub got !CONFIG_SECURITY
> >
> > An arm multi_v7_defconfig fails like this:
> >
> > init/main.c: In function 'start_kernel':
> > init/main.c:596:2: error: implicit declaration of function 'early_security_init'; did you mean 'security_init'? [-Werror=implicit-function-declaration]
> > early_security_init();
> > ^~~~~~~~~~~~~~~~~~~
> > security_init
> >
> > Fixes: 45d29f9e9b8b ("security: Support early LSMs")
> > Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
>
> Acked-by: Kees Cook <keescook@chromium•org>
>
> -Kees
>
> > ---
> > include/linux/security.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/include/linux/security.h b/include/linux/security.h
> > index 807dc0d24982..23e1c3f17d48 100644
> > --- a/include/linux/security.h
> > +++ b/include/linux/security.h
> > @@ -473,6 +473,11 @@ static inline int security_init(void)
> > return 0;
> > }
> >
> > +static inline int early_security_init(void)
> > +{
> > + return 0;
> > +}
> > +
> > static inline int security_binder_set_context_mgr(struct task_struct *mgr)
> > {
> > return 0;
> > --
> > 2.20.1
I am still applying that patch ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-19 3:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 4:58 linux-next: build failure after merge of the security tree Stephen Rothwell
2019-08-12 17:34 ` Kees Cook
2019-08-19 3:21 ` Stephen Rothwell [this message]
2019-08-19 3:38 ` Stephen Rothwell
2019-08-21 16:39 ` James Morris
-- strict thread matches above, loose matches on Subject: below --
2026-06-02 16:16 Mark Brown
2026-06-02 16:31 ` Paul Moore
2026-06-02 16:52 ` Daniel Borkmann
2026-06-02 17:26 ` Paul Moore
2026-06-02 18:40 ` Paul Moore
2026-06-02 19:16 ` Mark Brown
2026-06-02 20:13 ` Paul Moore
2026-06-02 21:45 ` Paul Moore
2026-06-03 12:42 ` Mark Brown
2026-06-03 14:43 ` Paul Moore
2025-03-24 4:37 Stephen Rothwell
2025-02-10 1:18 Stephen Rothwell
2025-02-10 3:44 ` Paul Moore
2025-02-10 3:53 ` Stephen Rothwell
2025-02-10 14:51 ` Paul Moore
2020-07-08 4:00 Stephen Rothwell
2020-07-13 2:04 ` Stephen Rothwell
2020-07-13 2:06 ` Stephen Rothwell
2020-07-29 23:35 ` Stephen Rothwell
2020-07-30 2:35 ` James Morris
2020-07-30 2:59 ` Stephen Rothwell
2020-07-30 5:03 ` Stephen Rothwell
2020-08-04 3:36 ` James Morris
2017-08-23 11:12 Stephen Rothwell
2017-08-17 2:51 Stephen Rothwell
2017-08-17 3:24 ` Kees Cook
2016-05-19 4:01 Stephen Rothwell
[not found] ` <20160519140120.23b345a1-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2016-05-19 10:11 ` David Howells
2016-05-19 23:14 ` Stephen Rothwell
2016-05-20 3:07 ` Steve French
2015-08-17 5:29 Stephen Rothwell
2015-08-17 6:04 ` Stephen Rothwell
2015-08-26 14:45 ` David Howells
2014-07-25 9:21 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819132119.7349e881@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=casey@schaufler-ca$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mjg59@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox