Subject: Coverity: dsa_switch_probe(): Null pointer dereferences

From: coverity-bot <[email-masked]>
Date: Mon, 28 Oct 2019 16:01:52 -0700

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")

Coverity reported the following:

*** CID 1487378:  Null pointer dereferences  (REVERSE_INULL)
/net/dsa/dsa2.c: 849 in dsa_switch_probe()
843     static int dsa_switch_probe(struct dsa_switch *ds)
844     {
845     	struct dsa_chip_data *pdata = ds->dev->platform_data;
846     	struct device_node *np = ds->dev->of_node;
847     	int err;
848
vvv     CID 1487378:  Null pointer dereferences  (REVERSE_INULL)
vvv     Null-checking "ds->dev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
849     	if (!ds->dev)
850     		return -ENODEV;
851
852     	if (!ds->num_ports)
853     		return -EINVAL;
854

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1487378 ("Null pointer dereferences")
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")

Thanks for your attention!

-- 
Coverity-bot