Subject: Coverity: amdgpu_dm_commit_planes(): Null pointer dereferences

From: coverity-bot <[email-masked]>
Date: Mon, 4 Nov 2019 09:41:15 -0800

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

74aa7bd4c6f7 ("drm/amd/display: Make stream commits call into DC only once")

Coverity reported the following:

*** CID 1487396:  Null pointer dereferences  (FORWARD_NULL)
/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: 5901 in amdgpu_dm_commit_planes()
5895
5896     		if (dc_plane && !dc_plane->tiling_info.gfx9.swizzle)
5897     			swizzle = false;
5898
5899     		bundle->surface_updates[planes_count].surface = dc_plane;
5900     		if (new_pcrtc_state->color_mgmt_changed) {
vvv     CID 1487396:  Null pointer dereferences  (FORWARD_NULL)
vvv     Dereferencing null pointer "dc_plane".
5901     			bundle->surface_updates[planes_count].gamma = dc_plane->gamma_correction;
5902     			bundle->surface_updates[planes_count].in_transfer_func = dc_plane->in_transfer_func;
5903     		}
5904
5905     		fill_dc_scaling_info(new_plane_state,
5906     				     &bundle->scaling_infos[planes_count]);

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1487396 ("Null pointer dereferences")
Fixes: 74aa7bd4c6f7 ("drm/amd/display: Make stream commits call into DC only once")

Thanks for your attention!

-- 
Coverity-bot