Subject: Coverity: transmitter_control_dmcub(): Memory - corruptions

From: coverity-bot <[email-masked]>
Date: Mon, 11 Nov 2019 17:35:43 -0800

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191108 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

c264644545d2 ("drm/amd/display: Add DMUB support to DC")

Coverity reported the following:

*** CID 1487842:  Memory - corruptions  (OVERRUN)
/drivers/gpu/drm/amd/display/dc/bios/command_table2.c: 225 in transmitter_control_dmcub()
219     {
220     	struct dmub_rb_cmd_dig1_transmitter_control transmitter_control;
221
222     	transmitter_control.header.type = DMUB_CMD__DIG1_TRANSMITTER_CONTROL;
223     	transmitter_control.transmitter_control.dig = *dig;
224
vvv     CID 1487842:  Memory - corruptions  (OVERRUN)
vvv     Overrunning struct type dmub_cmd_header of 4 bytes by passing it to a function which accesses it at byte offset 63.
225     	dc_dmub_srv_cmd_queue(dmcub, &transmitter_control.header);
226     	dc_dmub_srv_cmd_execute(dmcub);
227     	dc_dmub_srv_wait_idle(dmcub);
228     }
229
230     static enum bp_result transmitter_control_v1_6(

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1487842 ("Memory - corruptions")
Fixes: c264644545d2 ("drm/amd/display: Add DMUB support to DC")

Thanks for your attention!

-- 
Coverity-bot