Subject: Re: linux-next: Tree for Jan 24 (kvm)

From: Sean Christopherson <[email-masked]>
Date: Fri, 24 Jan 2020 13:33:26 -0800

On Fri, Jan 24, 2020 at 12:59:56PM -0800, Randy Dunlap wrote:
> On 1/24/20 12:51 PM, Randy Dunlap wrote:
> > On 1/23/20 10:33 PM, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Changes since 20200123:
> >>
> >> The kvm tree gained a conflict against Linus' tree.
> >>
> > 
> > on i386:
> > 
> > ../arch/x86/kvm/x86.h:363:16: warning: right shift count >= width of type [-Wshift-count-overflow]
> > 
> > 
> 
> Sorry, I missed these 2 warnings:
> 
> ../arch/x86/kvm/vmx/vmx.c: In function 'vmx_set_msr':
> ../arch/x86/kvm/vmx/vmx.c:2001:14: warning: '~' on a boolean expression [-Wbool-operation]
>    if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
>               ^
> 
> 
> ../arch/x86/kvm/svm.c: In function 'svm_set_msr':
> ../arch/x86/kvm/svm.c:4289:14: warning: '~' on a boolean expression [-Wbool-operation]
>    if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
>               ^
> ../arch/x86/kvm/svm.c:4289:14: note: did you mean to use logical not?
>    if (data & ~kvm_spec_ctrl_valid_bits(vcpu))
>               ^
>               !

Paolo has a fix in the works for this[1], pretty sure he's going to fixup
the offending commit directly[2].

Thanks!

[1] https://lkml.kernel.org/r/[email-masked]
[2] https://lkml.kernel.org/r/[email-masked]

> -- 
> ~Randy