Subject: Re: linux-next: Tree for Feb 6 (objtool warning)

From: Josh Poimboeuf <[email-masked]>
Date: Thu, 6 Feb 2020 12:04:07 -0600

On Thu, Feb 06, 2020 at 08:10:20AM -0800, Randy Dunlap wrote:
> On 2/5/20 8:09 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Please do not add any v5.7 material to your linux-next included
> > branches until after v5.6-rc1 has been released.
> > 
> > Changes since 20200205:
> > 
> 
> drivers/pinctrl/pinctrl-ingenic.o: warning: objtool: ingenic_pinconf_set() falls through to next function ingenic_pinconf_group_set()

Thanks Randy.  I'm able to recreate with the config.  Objtool is
confused by the unreachable() statement in ingenic_pinconf_set().

I think a BUG() would be more appropriate anyway.  Will post a proper
patch.

diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index 96f04d121ebd..6b61ac6cd4d2 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -2158,7 +2158,7 @@ static int ingenic_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
 			break;
 
 		default:
-			unreachable();
+			BUG();
 		}
 	}