Subject: Re: linux-next: build failure after merge of the hwmon-fixes tree

From: Guenter Roeck <[email-masked]>
Date: Tue, 25 Feb 2020 13:25:56 -0800

On Wed, Feb 26, 2020 at 08:12:28AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-fixes tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/hwmon/pmbus/xdpe12284.c: In function 'xdpe122_read_word_data':
> drivers/hwmon/pmbus/xdpe12284.c:33:9: error: too many arguments to function 'pmbus_read_word_data'
>    33 |   ret = pmbus_read_word_data(client, page, phase, reg);
>       |         ^~~~~~~~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/xdpe12284.c:13:
> drivers/hwmon/pmbus/pmbus.h:458:5: note: declared here
>   458 | int pmbus_read_word_data(struct i2c_client *client, int page, u8 reg);
>       |     ^~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/xdpe12284.c: At top level:
> drivers/hwmon/pmbus/xdpe12284.c:127:20: error: initialization of 'int (*)(struct i2c_client *, int,  int)' from incompatible pointer type 'int (*)(struct i2c_client *, int,  int,  int)' [-Werror=incompatible-pointer-types]
>   127 |  .read_word_data = xdpe122_read_word_data,
>       |                    ^~~~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/xdpe12284.c:127:20: note: (near initialization for 'xdpe122_info.read_word_data')
> 
> Caused by commit
> 
>   47555027eae2 ("hwmon: (pmbus/xdpe12284) Add callback for vout limits conversion")
> 
> I have reverted that commit for today.
> 

Bummer. My fault; sorry for that. Fixed up now.

Thanks,
Guenter