From: Roman Gushchin <guro@fb•com>
To: "Guido Günther" <agx@sigxcpu•org>
Cc: <linux-kernel@vger•kernel.org>, <linux-next@vger•kernel.org>
Subject: Re: linux-next build failure on arm64 with CMA but !NUMA
Date: Wed, 18 Mar 2020 08:37:02 -0700 [thread overview]
Message-ID: <20200318153702.GA22501@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20200318114109.GA65068@bogon.m.sigxcpu.org>
On Wed, Mar 18, 2020 at 12:41:09PM +0100, Guido Günther wrote:
> Hi Roman,
> 882d60d2ce725381236a158204d7ec13ff19ab25 in linux-next broke compilation
> on arm64 CMA && !NUMA like
>
> CC kernel/irq/irqdesc.o
> mm/hugetlb.c: In function ‘hugetlb_cma_reserve’:
> mm/hugetlb.c:5449:3: error: implicit declaration of function ‘for_each_mem_pfn_range’; did you mean ‘for_each_mem_range’? [-Werror=implicit-function-declaration]
> for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
> ^~~~~~~~~~~~~~~~~~~~~~
> for_each_mem_range
> mm/hugetlb.c:5449:61: error: expected ‘;’ before ‘{’ token
> for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
> ^~
> Reverting that fixes the build for the moment. Would making all of this
> dependent on CMA && NUMA be the right fix?
Hello Guido!
Thank you for the report!
We've been discussing the issue for a couple of days, and I've proposed a fix.
I've just resent it to linux-mm@ (you're in cc), so hopefully it will be merged today.
Thanks!
prev parent reply other threads:[~2020-03-18 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 11:41 linux-next build failure on arm64 with CMA but !NUMA Guido Günther
2020-03-18 15:37 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318153702.GA22501@carbon.DHCP.thefacebook.com \
--to=guro@fb$(echo .)com \
--cc=agx@sigxcpu$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox