Subject: linux-next: build failure after merge of the input tree

From: Stephen Rothwell <[email-masked]>
Date: Wed, 25 Mar 2020 18:16:00 +1100

Hi all,

After merging the input tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_output':
drivers/input/touchscreen/goodix.c:624:12: error: implicit declaration of function 'acpi_execute_simple_method' [-Werror=implicit-function-declaration]
  624 |   status = acpi_execute_simple_method(ACPI_HANDLE(dev),
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/goodix.c:606:17: warning: unused variable 'dev' [-Wunused-variable]
  606 |  struct device *dev = &ts->client->dev;
      |                 ^~~
drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_input':
drivers/input/touchscreen/goodix.c:634:17: warning: unused variable 'dev' [-Wunused-variable]
  634 |  struct device *dev = &ts->client->dev;
      |                 ^~~
cc1: some warnings being treated as errors

Caused by commit

  c5fca485320e ("Input: goodix - add support for controlling the IRQ pin through ACPI methods")

I have applied the following patch for today:

From: Stephen Rothwell <[email-masked]>
Date: Wed, 25 Mar 2020 18:04:08 +1100
Subject: [PATCH] Input: goodix - mark as BROKEN for noe

Signed-off-by: Stephen Rothwell <[email-masked]>
---
 drivers/input/touchscreen/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index c071f7c407b6..98788fb83917 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -380,6 +380,7 @@ config TOUCHSCREEN_GOODIX
 	tristate "Goodix I2C touchscreen"
 	depends on I2C
 	depends on GPIOLIB || COMPILE_TEST
+	depends on BROKEN
 	help
 	  Say Y here if you have the Goodix touchscreen (such as one
 	  installed in Onda v975w tablets) connected to your
-- 
2.25.0

-- 
Cheers,
Stephen Rothwell