From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Dmitry Torokhov <dmitry.torokhov@gmail•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Hans de Goede <hdegoede@redhat•com>
Subject: Re: linux-next: build failure after merge of the input tree
Date: Wed, 1 Apr 2020 08:06:24 +1100 [thread overview]
Message-ID: <20200401080624.5c3b3891@canb.auug.org.au> (raw)
In-Reply-To: <20200325181600.207eb7ac@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2136 bytes --]
Hi all,
On Wed, 25 Mar 2020 18:16:00 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Hi all,
>
> After merging the input tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_output':
> drivers/input/touchscreen/goodix.c:624:12: error: implicit declaration of function 'acpi_execute_simple_method' [-Werror=implicit-function-declaration]
> 624 | status = acpi_execute_simple_method(ACPI_HANDLE(dev),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/input/touchscreen/goodix.c:606:17: warning: unused variable 'dev' [-Wunused-variable]
> 606 | struct device *dev = &ts->client->dev;
> | ^~~
> drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_input':
> drivers/input/touchscreen/goodix.c:634:17: warning: unused variable 'dev' [-Wunused-variable]
> 634 | struct device *dev = &ts->client->dev;
> | ^~~
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> c5fca485320e ("Input: goodix - add support for controlling the IRQ pin through ACPI methods")
>
> I have applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Wed, 25 Mar 2020 18:04:08 +1100
> Subject: [PATCH] Input: goodix - mark as BROKEN for noe
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index c071f7c407b6..98788fb83917 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -380,6 +380,7 @@ config TOUCHSCREEN_GOODIX
> tristate "Goodix I2C touchscreen"
> depends on I2C
> depends on GPIOLIB || COMPILE_TEST
> + depends on BROKEN
> help
> Say Y here if you have the Goodix touchscreen (such as one
> installed in Onda v975w tablets) connected to your
I am still marking this as BROKEN ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-31 21:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 7:16 linux-next: build failure after merge of the input tree Stephen Rothwell
2020-03-31 21:06 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-25 16:22 Mark Brown
2026-03-25 16:25 ` Dmitry Torokhov
2025-07-02 3:47 Stephen Rothwell
2025-07-02 4:01 ` Dmitry Torokhov
2022-10-24 23:00 Stephen Rothwell
2022-10-25 5:02 ` Dmitry Torokhov
2022-08-17 0:00 Stephen Rothwell
2022-08-17 0:07 ` Stephen Rothwell
2022-08-17 4:43 ` Uwe Kleine-König
2022-08-01 21:44 broonie
2022-08-04 12:33 ` Mark Brown
2022-08-04 23:36 ` Jiri Kosina
2022-04-27 0:48 Stephen Rothwell
2022-04-27 6:53 ` Fabien Parent
2022-04-27 7:35 ` Lee Jones
2022-04-27 7:41 ` Fabien Parent
2022-05-02 2:17 ` Stephen Rothwell
2022-05-06 0:25 ` Dmitry Torokhov
2022-05-31 10:13 ` Fabien Parent
2015-10-16 2:19 Stephen Rothwell
2015-10-16 7:37 ` Hans de Goede
2015-10-17 16:39 ` Dmitry Torokhov
2015-07-24 1:49 Stephen Rothwell
2015-07-24 2:33 ` Dmitry Torokhov
2012-10-05 1:47 Stephen Rothwell
2012-10-05 6:12 ` Dmitry Torokhov
2012-01-24 3:25 Stephen Rothwell
2012-01-24 6:59 ` Dmitry Torokhov
2012-01-24 23:16 ` John Stultz
2010-08-19 1:35 Stephen Rothwell
2010-08-19 5:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401080624.5c3b3891@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox