Subject: Re: linux-next: Tree for Apr 20

From: Stephen Rothwell <[email-masked]>
Date: Mon, 20 Apr 2020 17:25:59 +1000

Hi all,

On Mon, 20 Apr 2020 09:14:15 +0200 Christian Borntraeger <[email-masked]> wrote:
>
> s390 defconfig still does not compile. While the media kconfig problem is gone I now have
> 
>   CC [M]  drivers/char/hw_random/cctrng.o
> drivers/char/hw_random/cctrng.c: In function ‘cc_trng_compwork_handler’:
> drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared (first use in this function); did you mean ‘vdso_enabled’?
>   334 |  if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
>       |                                                 ^~~~~~~~~~~~
>       |                                                 vdso_enabled
> drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
> drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ‘fips_fail_notify’ [-Werror=implicit-function-declaration]
>   335 |   fips_fail_notify();
>       |   ^~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> 
> Can we maybe make this driver depend on ARM?

Caused by commit

  a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")

which has neglected to include linux/fips.h ...

-- 
Cheers,
Stephen Rothwell