From: Stephen Rothwell <sfr@canb•auug.org.au>
To: John Stultz <john.stultz@linaro•org>
Cc: Andy Gross <agross@kernel•org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Stephen Boyd <swboyd@chromium•org>,
Bjorn Andersson <bjorn.andersson@linaro•org>
Subject: Re: linux-next: build failure after merge of the qcom tree
Date: Mon, 18 May 2020 15:16:35 +1000 [thread overview]
Message-ID: <20200518151635.5b36916b@canb.auug.org.au> (raw)
In-Reply-To: <CALAqxLUub7SqPQbKJ+OnPtcQhLiu0aFD9YudhDtDfDLNXL6smQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]
Hi all,
On Mon, 20 Apr 2020 19:41:56 -0700 John Stultz <john.stultz@linaro•org> wrote:
>
> On Mon, Apr 20, 2020 at 4:29 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > On Tue, 14 Apr 2020 18:18:11 -0700 John Stultz <john.stultz@linaro•org> wrote:
> > >
> > > On Tue, Apr 14, 2020 at 5:41 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > > >
> > > > After merging the qcom tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/soc/qcom/rpmh-rsc.c: In function '__tcs_buffer_write':
> > > > drivers/soc/qcom/rpmh-rsc.c:484:3: error: implicit declaration of function 'trace_rpmh_send_msg_rcuidle'; did you mean 'trace_rpmh_send_msg_enabled'? [-Werror=implicit-function-declaration]
> > > > 484 | trace_rpmh_send_msg_rcuidle(drv, tcs_id, j, msgid, cmd);
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > | trace_rpmh_send_msg_enabled
> > > > cc1: some warnings being treated as errors
> > > >
> > > > I don't know why this error only started happening today. However
> > > > reverting commit
> > > >
> > > > 1d3c6f86fd3f ("soc: qcom: rpmh: Allow RPMH driver to be loaded as a module")
> > > >
> > > > fixes the build, so I have done that for today.
> > >
> > >
> > > Ah. I'm guessing the newly added rpmh-rsc code depends on rpmh being built in.
> > >
> > > I'll take a look at it.
> >
> > I am still reverting that commit.
>
> Yea. I've stirred up some discussion on it, but its fairly
> complicated. Unfortunately I suspect it will take some time to confirm
> and justify the change I think is needed, so I think reverting this is
> the best short term plan.
I am still reverting that commit. It is probably time (we are beyond
-rc6 now) that it is either reverted or fixed in the qcom tree, please.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-18 5:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:41 linux-next: build failure after merge of the qcom tree Stephen Rothwell
2020-04-15 1:18 ` John Stultz
2020-04-20 23:29 ` Stephen Rothwell
2020-04-21 2:41 ` John Stultz
2020-05-18 5:16 ` Stephen Rothwell [this message]
2020-05-18 6:19 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2024-08-01 23:48 Stephen Rothwell
2024-08-05 6:39 ` Satya Priya Kakitapalli (Temp)
2024-06-25 11:36 Mark Brown
2024-07-01 1:22 ` Stephen Rothwell
2023-12-03 23:30 Stephen Rothwell
2023-12-03 23:23 Stephen Rothwell
2023-09-20 22:42 Stephen Rothwell
2023-09-21 6:30 ` Luca Weiss
2022-11-07 22:00 Stephen Rothwell
2022-11-07 22:15 ` Matti Lehtimäki
2022-11-08 1:30 ` Bjorn Andersson
2021-10-24 23:43 Stephen Rothwell
2021-10-25 2:37 ` Bjorn Andersson
2019-04-23 23:25 Stephen Rothwell
2019-04-23 23:50 ` Matthias Kaehlcke
2018-04-25 22:40 Stephen Rothwell
2018-04-26 3:39 ` Evan Green
2018-04-26 4:52 ` Stephen Rothwell
2018-04-26 16:42 ` Evan Green
2018-04-26 21:23 ` Andy Gross
2016-03-31 23:28 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518151635.5b36916b@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=agross@kernel$(echo .)org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=john.stultz@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=swboyd@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox