From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Qian Cai <cai@lca•pw>
Cc: Guo Xuenan <guoxuenan@huawei•com>,
axboe@kernel•dk, linux-block@vger•kernel.org,
wangli74@huawei•com, fangwei1@huawei•com, ming.lei@redhat•com,
josef@toxicpanda•com, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait.
Date: Wed, 15 Jul 2020 12:19:42 +1000 [thread overview]
Message-ID: <20200715121942.33bb34d8@canb.auug.org.au> (raw)
In-Reply-To: <20200714232123.GA49251@lca.pw>
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
Hi all,
On Tue, 14 Jul 2020 19:21:24 -0400 Qian Cai <cai@lca•pw> wrote:
>
> On Sun, Jun 28, 2020 at 09:56:25AM -0400, Guo Xuenan wrote:
> > It is no need do finish_wait twice after acquiring inflight.
> >
> > Signed-off-by: Guo Xuenan <guoxuenan@huawei•com>
> > ---
> > block/blk-rq-qos.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
> > index 656460636ad3..18f3eab9f768 100644
> > --- a/block/blk-rq-qos.c
> > +++ b/block/blk-rq-qos.c
> > @@ -273,8 +273,6 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
> > if (data.got_token)
> > break;
> > if (!has_sleeper && acquire_inflight_cb(rqw, private_data)) {
> > - finish_wait(&rqw->wait, &data.wq);
> > -
> > /*
> > * We raced with wbt_wake_function() getting a token,
> > * which means we now have two. Put our local token
> > --
> > 2.25.4
>
> Reverting this commit fixed an issue that swapping workloads will stall for
> days without being able to make any progress below.
I have reverted that commit from linux-next today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-15 2:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200628135625.3396636-1-guoxuenan@huawei.com>
2020-07-14 23:21 ` [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait Qian Cai
2020-07-15 2:19 ` Stephen Rothwell [this message]
2020-07-15 15:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715121942.33bb34d8@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=axboe@kernel$(echo .)dk \
--cc=cai@lca$(echo .)pw \
--cc=fangwei1@huawei$(echo .)com \
--cc=guoxuenan@huawei$(echo .)com \
--cc=josef@toxicpanda$(echo .)com \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=ming.lei@redhat$(echo .)com \
--cc=wangli74@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox