From: Will Deacon <will@kernel•org>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: Peter Zijlstra <peterz@infradead•org>,
Petr Mladek <pmladek@suse•com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail•com>,
Steven Rostedt <rostedt@goodmis•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Ingo Molnar <mingo@redhat•com>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Christian Borntraeger <borntraeger@de•ibm.com>,
linux-s390@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail•com>
Subject: Re: [PATCH RESEND] lockdep: Move list.h inclusion into lockdep.h
Date: Thu, 16 Jul 2020 09:30:49 +0100 [thread overview]
Message-ID: <20200716083049.GA6771@willie-the-truck> (raw)
In-Reply-To: <20200716063649.GA23065@gondor.apana.org.au>
On Thu, Jul 16, 2020 at 04:36:50PM +1000, Herbert Xu wrote:
> Currently lockdep_types.h includes list.h without actually using any
> of its macros or functions. All it needs are the type definitions
> which were moved into types.h long ago. This potentially causes
> inclusion loops because both are included by many core header
> files.
>
> This patch moves the list.h inclusion into lockdep.h. Note that
> we could probably remove it completely but that could potentially
> result in compile failures should any end users not include list.h
> directly and also be unlucky enough to not get list.h via some other
> header file.
>
> Reported-by: Petr Mladek <pmladek@suse•com>
> Tested-by: Petr Mladek <pmladek@suse•com>
> Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>
Acked-by: Will Deacon <will@kernel•org>
Will
next prev parent reply other threads:[~2020-07-16 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 6:36 [PATCH RESEND] lockdep: Move list.h inclusion into lockdep.h Herbert Xu
2020-07-16 8:30 ` Will Deacon [this message]
[not found] <20200617071524.GA3055@gondor.apana.org.au>
[not found] ` <E1jlSJz-0003hE-8g@fornost.hmeau.com>
[not found] ` <20200617082459.GC2531@hirez.programming.kicks-ass.net>
[not found] ` <20200617122449.GX31238@alley>
[not found] ` <20200618143735.GJ576905@hirez.programming.kicks-ass.net>
2020-07-07 3:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716083049.GA6771@willie-the-truck \
--to=will@kernel$(echo .)org \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=mingo@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sergey.senozhatsky@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox