From: Alan Stern <stern@rowland•harvard.edu>
To: Bixuan Cui <cuibixuan@huawei•com>
Cc: linux-next@vger•kernel.org, gustavoars@kernel•org,
gregkh@linuxfoundation•org, linux-kernel@vger•kernel.org,
linux-usb@vger•kernel.org, qiang.zhang@windriver•com,
"Wanghui \(John\)" <john.wanghui@huawei•com>
Subject: Re: [PATCH -next v2] usb: usbtest: reduce stack usage in test_queue
Date: Thu, 16 Jul 2020 11:45:10 -0400 [thread overview]
Message-ID: <20200716154510.GE1112537@rowland.harvard.edu> (raw)
In-Reply-To: <42fe1a83-38a5-816b-9258-8a344008f398@huawei.com>
On Thu, Jul 16, 2020 at 09:47:10PM +0800, Bixuan Cui wrote:
> Fix the warning: [-Werror=-Wframe-larger-than=]
>
> drivers/usb/misc/usbtest.c: In function 'test_queue':
> drivers/usb/misc/usbtest.c:2148:1:
> warning: the frame size of 1232 bytes is larger than 1024 bytes
>
> Reported-by: kbuild test robot <lkp@intel•com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei•com>
> ---
> drivers/usb/misc/usbtest.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> index 8b220d56647b..a9b40953d6bc 100644
> --- a/drivers/usb/misc/usbtest.c
> +++ b/drivers/usb/misc/usbtest.c
> @@ -2043,7 +2043,7 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param,
> unsigned i;
> unsigned long packets = 0;
> int status = 0;
> - struct urb *urbs[MAX_SGLEN];
> + struct urb **urbs;
>
> if (!param->sglen || param->iterations > UINT_MAX / param->sglen)
> return -EINVAL;
> @@ -2051,6 +2051,10 @@ test_queue(struct usbtest_dev *dev, struct usbtest_param_32 *param,
> if (param->sglen > MAX_SGLEN)
> return -EINVAL;
>
> + urbs = kcalloc(MAX_SGLEN, sizeof(*urbs), GFP_KERNEL);
Since you know at runtime how many URBs will be needed, why not use that
information? Change MAX_SGLEN to param->sglen.
Aside from that,
Acked-by: Alan Stern <stern@rowland•harvard.edu>
Alan Stern
next prev parent reply other threads:[~2020-07-16 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:27 [PATCH] usb: usbtest: reduce stack usage in test_queue Bixuan Cui
2020-07-16 13:47 ` [PATCH -next v2] " Bixuan Cui
2020-07-16 14:26 ` Greg KH
2020-07-17 0:25 ` Bixuan Cui
2020-07-16 15:45 ` Alan Stern [this message]
2020-07-17 0:22 ` Bixuan Cui
2020-07-17 0:22 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716154510.GE1112537@rowland.harvard.edu \
--to=stern@rowland$(echo .)harvard.edu \
--cc=cuibixuan@huawei$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gustavoars@kernel$(echo .)org \
--cc=john.wanghui@huawei$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=qiang.zhang@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox