Subject: Re: linux-next: Tree for Aug 19 (scsi/libsas/)

From: Stephen Rothwell <[email-masked]>
Date: Wed, 19 Aug 2020 18:09:34 +1000

Hi Randy,

On Tue, 18 Aug 2020 23:30:36 -0700 Randy Dunlap <[email-masked]> wrote:
>
> Is this some kind of mis-merge?
> 
> In sas_discover.c:
> 
> 	case SAS_SATA_DEV:
> 	case SAS_SATA_PM:
> #ifdef CONFIG_SCSI_SAS_ATA
> 		error = sas_discover_sata(dev);
> 		break;
> #else
> 		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
> 		fallthrough;
> #endif
> 		fallthrough;	/* only for the #else condition above */

No, that comes from commit

  58e813cceabd ("treewide: Use fallthrough pseudo-keyword")

from the kspp-gustavo tree.

>   CC [M]  drivers/scsi/libsas/sas_discover.o
> In file included from ./../include/linux/compiler_types.h:65:0,
>                  from <command-line>:0:
> ../drivers/scsi/libsas/sas_discover.c: In function 'sas_discover_domain':
> ../include/linux/compiler_attributes.h:214:41: warning: attribute 'fallthrough' not preceding a case label or default label
>  # define fallthrough                    __attribute__((__fallthrough__))
>                                          ^
> ../drivers/scsi/libsas/sas_discover.c:469:3: note: in expansion of macro 'fallthrough'
>    fallthrough;
>    ^~~~~~~~~~~
>   CC      drivers/ide/ide-eh.o
> ../include/linux/compiler_attributes.h:214:41: error: invalid use of attribute 'fallthrough'
>  # define fallthrough                    __attribute__((__fallthrough__))
>                                          ^
> ../drivers/scsi/libsas/sas_discover.c:471:3: note: in expansion of macro 'fallthrough'
>    fallthrough; /* only for the #else condition above */
>    ^~~~~~~~~~~

-- 
Cheers,
Stephen Rothwell