Subject: Re: linux-next: Tree for Sep 9 (drivers/usb/typec/mux/intel_pmc_mux.c)

From: Heikki Krogerus <[email-masked]>
Date: Thu, 10 Sep 2020 13:49:11 +0300

On Wed, Sep 09, 2020 at 09:04:53AM -0700, Randy Dunlap wrote:
> On 9/9/20 3:26 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20200908:
> > 
> 
> on x86_64:
> 
>   CC [M]  drivers/usb/typec/mux/intel_pmc_mux.o
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘update_port_status’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:151:21: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
>   port->iom_status = readl(port->pmc->iom_base + IOM_PORT_STATUS_OFFSET +
>                      ^~~~~
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘is_memory’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:524:10: error: implicit declaration of function ‘acpi_dev_resource_memory’; did you mean ‘acpi_os_read_memory’? [-Werror=implicit-function-declaration]
>   return !acpi_dev_resource_memory(res, &r);
>           ^~~~~~~~~~~~~~~~~~~~~~~~
>           acpi_os_read_memory
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘pmc_usb_probe_iom’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:539:8: error: implicit declaration of function ‘acpi_dev_get_resources’; did you mean ‘acpi_get_event_resources’? [-Werror=implicit-function-declaration]
>   ret = acpi_dev_get_resources(adev, &resource_list, is_memory, NULL);
>         ^~~~~~~~~~~~~~~~~~~~~~
>         acpi_get_event_resources
>   CC      drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o
> ../drivers/usb/typec/mux/intel_pmc_mux.c:547:2: error: implicit declaration of function ‘acpi_dev_free_resource_list’; did you mean ‘acpi_get_event_resources’? [-Werror=implicit-function-declaration]
>   acpi_dev_free_resource_list(&resource_list);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   acpi_get_event_resources
> ../drivers/usb/typec/mux/intel_pmc_mux.c:550:19: error: dereferencing pointer to incomplete type ‘struct acpi_device’
>    put_device(&adev->dev);

It looks like we are missing ACPI dependency in Kconfig and a include.
I'll prepare the fixes.

Thanks Randy,

-- 
heikki