From: Mika Westerberg <mika.westerberg@linux•intel.com>
To: Bartosz Golaszewski <brgl@bgdev•pl>
Cc: Linus Walleij <linus.walleij@linaro•org>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Kent Gibson <warthog618@gmail•com>,
Anders Roxell <anders.roxell@linaro•org>,
linux-gpio@vger•kernel.org, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre•com>
Subject: Re: [PATCH next v2] gpiolib: check for parent device in devprop_gpiochip_set_names()
Date: Thu, 17 Sep 2020 12:55:14 +0300 [thread overview]
Message-ID: <20200917095514.GO2495@lahna.fi.intel.com> (raw)
In-Reply-To: <20200917074857.6716-1-brgl@bgdev.pl>
On Thu, Sep 17, 2020 at 09:48:57AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre•com>
>
> It's possible for a GPIO chip to not have a parent device (whose
> properties we inspect for 'gpio-line-names'). In this case we should
> simply return from devprop_gpiochip_set_names(). Add an appropriate
> check for this use-case.
>
> Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties")
> Reported-by: Anders Roxell <anders.roxell@linaro•org>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
> Tested-by: Anders Roxell <anders.roxell@linaro•org>
FWIW,
Reviewed-by: Mika Westerberg <mika.westerberg@linux•intel.com>
prev parent reply other threads:[~2020-09-17 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 7:48 [PATCH next v2] gpiolib: check for parent device in devprop_gpiochip_set_names() Bartosz Golaszewski
2020-09-17 9:55 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917095514.GO2495@lahna.fi.intel.com \
--to=mika.westerberg@linux$(echo .)intel.com \
--cc=anders.roxell@linaro$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=brgl@bgdev$(echo .)pl \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=warthog618@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox