From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>,
David Miller <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>
Subject: Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)
Date: Fri, 18 Sep 2020 18:37:17 +1000 [thread overview]
Message-ID: <20200918183717.7d25a71d@canb.auug.org.au> (raw)
In-Reply-To: <0b592973-55d6-b318-ed38-1d5fbd706e7a@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
Hi Randy,
On Thu, 17 Sep 2020 13:45:52 -0700 Randy Dunlap <rdunlap@infradead•org> wrote:
>
> Maybe some older versions of gcc just can't handle IS_ENABLED() inside an
> if (expression) very well.
>
> > gcc --version
> gcc (SUSE Linux) 7.5.0
>
> This patch:
>
> commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968
> Author: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> Date: Wed May 13 15:58:43 2020 +0200
>
> netns: enable to inherit devconf from current netns
>
> causes a build error:
>
> ../net/ipv4/devinet.c: In function ‘devinet_init_net’:
> ../net/ipv4/devinet.c:2672:7: error: ‘sysctl_devconf_inherit_init_net’ undeclared (first use in this function); did you mean ‘devinet_init_net’?
> sysctl_devconf_inherit_init_net == 3) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> devinet_init_net
> ../net/ipv4/devinet.c:2672:7: note: each undeclared identifier is reported only
With your config, can you try creating net/ipv4/devinet.i (preprocessed) file and
see if sysctl_devconf_inherit_init_net is actually declared? I
couldn't see any obvious way it is not, but that would explain the
error.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-18 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 10:23 linux-next: Tree for Sep 17 Stephen Rothwell
2020-09-17 20:33 ` linux-next: Tree for Sep 17 (netdevice.h: net_has_fallback_tunnels when SYSCTL is not set) Randy Dunlap
2020-09-18 3:52 ` Mahesh Bandewar (महेश बंडेवार)
2020-09-17 20:45 ` linux-next: Tree for Sep 17 (net/ipv4/devinet.c) Randy Dunlap
2020-09-18 8:25 ` Nicolas Dichtel
2020-09-18 20:46 ` Randy Dunlap
2020-09-18 8:37 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918183717.7d25a71d@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox