From: Randy Dunlap <rdunlap@infradead•org>
To: linux-kernel@vger•kernel.org
Cc: Randy Dunlap <rdunlap@infradead•org>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
Len Brown <len.brown@intel•com>, Pavel Machek <pavel@ucw•cz>,
linux-pm@vger•kernel.org,
Michael Turquette <mturquette@baylibre•com>,
Stephen Boyd <sboyd@kernel•org>,
linux-clk@vger•kernel.org, Taniya Das <tdas@codeaurora•org>,
linux-next@vger•kernel.org,
Nathan Chancellor <natechancellor@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>
Subject: [PATCH -next v2] clk: pm_clock: provide stubs for pm_clk_runtime_suspend/_resume
Date: Sun, 8 Nov 2020 19:21:15 -0800 [thread overview]
Message-ID: <20201109032115.10610-1-rdunlap@infradead.org> (raw)
Add stubs for pm_clk_runtime_suspend() and pm_clk_runtime_resume()
to fix build errors when CONFIG_PM and CONFIG_PM_CLK are not enabled.
Fixes these build errors:
../drivers/clk/qcom/camcc-sc7180.c: In function ‘cam_cc_sc7180_probe’:
../drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of function ‘pm_clk_runtime_resume’; did you mean ‘pm_runtime_resume’? [-Werror=implicit-function-declaration]
ret = pm_clk_runtime_resume(&pdev->dev);
^~~~~~~~~~~~~~~~~~~~~
../drivers/clk/qcom/camcc-sc7180.c:1681:3: error: implicit declaration of function ‘pm_clk_runtime_suspend’; did you mean ‘pm_runtime_suspend’? [-Werror=implicit-function-declaration]
pm_clk_runtime_suspend(&pdev->dev);
^~~~~~~~~~~~~~~~~~~~~~
Fixes: 15d09e830bbc ("clk: qcom: camcc: Add camera clock controller driver for SC7180")
Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki•net>
Cc: Len Brown <len.brown@intel•com>
Cc: Pavel Machek <pavel@ucw•cz>
Cc: linux-pm@vger•kernel.org
Cc: Michael Turquette <mturquette@baylibre•com>
Cc: Stephen Boyd <sboyd@kernel•org>
Cc: linux-clk@vger•kernel.org
Cc: Taniya Das <tdas@codeaurora•org>
Cc: linux-next@vger•kernel.org
Cc: Nathan Chancellor <natechancellor@gmail•com>
Cc: Andrew Morton <akpm@linux-foundation•org>
---
v2: move the function stubs to be inside the #else (for !CONFIG_PM)
as suggested by Nathan to fix another build error
include/linux/pm_clock.h | 8 ++++++++
1 file changed, 8 insertions(+)
--- linux-next-20201106.orig/include/linux/pm_clock.h
+++ linux-next-20201106/include/linux/pm_clock.h
@@ -27,6 +27,14 @@ extern int pm_clk_runtime_resume(struct
.runtime_resume = pm_clk_runtime_resume,
#else
#define USE_PM_CLK_RUNTIME_OPS
+static inline int pm_clk_runtime_suspend(struct device *dev)
+{
+ return 0;
+}
+static inline int pm_clk_runtime_resume(struct device *dev)
+{
+ return 0;
+}
#endif
#ifdef CONFIG_PM_CLK
next reply other threads:[~2020-11-09 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 3:21 Randy Dunlap [this message]
2020-11-10 0:23 ` [PATCH -next v2] clk: pm_clock: provide stubs for pm_clk_runtime_suspend/_resume Stephen Rothwell
2020-11-10 1:09 ` Nathan Chancellor
2020-11-10 17:43 ` Rafael J. Wysocki
2020-11-10 21:30 ` Stephen Rothwell
2020-11-12 15:01 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109032115.10610-1-rdunlap@infradead.org \
--to=rdunlap@infradead$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=len.brown@intel$(echo .)com \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=mturquette@baylibre$(echo .)com \
--cc=natechancellor@gmail$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rjw@rjwysocki$(echo .)net \
--cc=sboyd@kernel$(echo .)org \
--cc=tdas@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox