From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Sven Schnelle <svens@linux•ibm.com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Christian Borntraeger <borntraeger@de•ibm.com>,
Thomas Gleixner <tglx@linutronix•de>,
Frederic Weisbecker <frederic@kernel•org>,
"Paul E. McKenney" <paulmck@kernel•org>
Subject: Re: [PATCH] s390: allow reschedule on syscall restart
Date: Fri, 22 Jan 2021 08:32:49 +1100 [thread overview]
Message-ID: <20210122083249.60d29c33@canb.auug.org.au> (raw)
In-Reply-To: <20210121143926.21440-2-svens@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
Hi all,
On Thu, 21 Jan 2021 15:39:26 +0100 Sven Schnelle <svens@linux•ibm.com> wrote:
>
> Commit 845f44e8ef28 ("sched: Report local wake up on resched blind zone
> within idle loop") from next-20210121 causes a warning because s390
> doesn't call sched_resched_local_allow() when restarting a syscall.
>
> Signed-off-by: Sven Schnelle <svens@linux•ibm.com>
> ---
> arch/s390/kernel/syscall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/s390/kernel/syscall.c b/arch/s390/kernel/syscall.c
> index bc8e650e377d..2b39ac40f970 100644
> --- a/arch/s390/kernel/syscall.c
> +++ b/arch/s390/kernel/syscall.c
> @@ -162,6 +162,7 @@ void noinstr __do_syscall(struct pt_regs *regs, int per_trap)
> do_syscall(regs);
> if (!test_pt_regs_flag(regs, PIF_SYSCALL_RESTART))
> break;
> + sched_resched_local_allow();
> local_irq_enable();
> }
> exit_to_user_mode();
I add that today as a merge fixup patch to the merge of the rcu tree
(which contains commit 845f44e8ef28 ("sched: Report local wake up on
resched blind zone within idle loop") ).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-21 21:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 14:39 Warning with next-20210121 on s390 Sven Schnelle
2021-01-21 14:39 ` [PATCH] s390: allow reschedule on syscall restart Sven Schnelle
2021-01-21 21:32 ` Stephen Rothwell [this message]
2021-01-21 21:43 ` Paul E. McKenney
2021-01-21 22:31 ` Stephen Rothwell
2021-01-26 6:59 ` Christian Borntraeger
2021-01-26 9:39 ` Sven Schnelle
2021-01-26 10:25 ` Stephen Rothwell
2021-01-26 15:12 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122083249.60d29c33@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=frederic@kernel$(echo .)org \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paulmck@kernel$(echo .)org \
--cc=svens@linux$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox