From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: Chanho Park <chanho61.park@samsung•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Krzysztof Kozlowski <krzk@kernel•org>
Subject: linux-next: build failure after merge of the pinctrl tree
Date: Wed, 27 Jan 2021 20:41:26 +1100 [thread overview]
Message-ID: <20210127204126.484d8f0a@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3250 bytes --]
Hi all,
After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/linux/wait.h:9,
from include/linux/pid.h:6,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
drivers/pinctrl/samsung/pinctrl-s3c64xx.c: In function 's3c64xx_irq_set_function':
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:20: error: passing argument 1 of 'spinlock_check' from incompatible pointer type [-Werror=incompatible-pointer-types]
289 | spin_lock_irqsave(&bank->slock, flags);
| ^~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
include/linux/spinlock.h:252:34: note: in definition of macro 'raw_spin_lock_irqsave'
252 | flags = _raw_spin_lock_irqsave(lock); \
| ^~~~
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:2: note: in expansion of macro 'spin_lock_irqsave'
289 | spin_lock_irqsave(&bank->slock, flags);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/wait.h:9,
from include/linux/pid.h:6,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
include/linux/spinlock.h:327:67: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
327 | static __always_inline raw_spinlock_t *spinlock_check(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [-Werror=incompatible-pointer-types]
296 | spin_unlock_irqrestore(&bank->slock, flags);
| ^~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
In file included from include/linux/wait.h:9,
from include/linux/pid.h:6,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
include/linux/spinlock.h:407:64: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
407 | static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags)
| ~~~~~~~~~~~~^~~~
Caused by commit
1f306ecbe0f6 ("pinctrl: samsung: use raw_spinlock for locking")
I have used the pinctrl tree from next-20210125 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2021-01-27 9:46 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 9:41 Stephen Rothwell [this message]
2021-01-27 12:40 ` linux-next: build failure after merge of the pinctrl tree Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2026-04-10 13:41 Mark Brown
2026-04-10 18:11 ` Linus Walleij
2025-10-28 2:23 Stephen Rothwell
2025-10-28 9:41 ` Linus Walleij
2025-07-14 7:08 Stephen Rothwell
2025-07-14 8:37 ` Luca Weiss
2025-07-14 15:54 ` Linus Walleij
2025-03-14 5:24 Stephen Rothwell
2025-03-14 11:03 ` Linus Walleij
2025-01-06 5:46 Stephen Rothwell
2025-01-08 21:47 ` Stephen Rothwell
2025-01-08 21:58 ` Linus Walleij
2025-01-09 11:27 ` Frank Wunderlich
2024-10-08 5:13 Stephen Rothwell
2024-10-09 16:02 ` Linus Walleij
2023-11-14 2:13 Stephen Rothwell
2023-11-14 7:46 ` Linus Walleij
2022-11-15 4:03 Stephen Rothwell
2022-11-10 4:09 Stephen Rothwell
2022-11-10 9:14 ` Linus Walleij
2022-11-09 2:46 Stephen Rothwell
2022-11-09 3:55 ` Yinbo Zhu
2022-11-09 8:31 ` Linus Walleij
2022-08-26 5:26 Stephen Rothwell
2022-08-26 8:01 ` Linus Walleij
2022-08-26 11:20 ` Wolfram Sang
2022-08-26 13:18 ` Linus Walleij
2022-09-12 13:40 ` Uwe Kleine-König
2022-08-02 22:21 broonie
2022-08-02 22:29 ` Mario Limonciello
2022-06-29 7:13 Stephen Rothwell
2022-06-27 6:01 Stephen Rothwell
2021-10-26 5:28 Stephen Rothwell
2021-10-26 12:30 ` Prathamesh Shete
2021-10-26 20:15 ` Linus Walleij
2021-10-26 21:21 ` Dmitry Osipenko
2021-10-28 12:31 ` Prathamesh Shete
2021-11-09 4:49 ` Linus Walleij
2021-03-04 1:12 Stephen Rothwell
2021-03-04 8:16 ` Linus Walleij
2021-03-04 9:54 ` Stephen Rothwell
[not found] ` <202103050813501649431@rock-chips.com>
2021-03-05 0:43 ` Linus Walleij
[not found] ` <202103050846457413391@rock-chips.com>
2021-03-05 2:12 ` Stephen Rothwell
2020-10-30 1:50 Stephen Rothwell
2020-11-04 3:10 ` Stephen Rothwell
2020-11-04 14:02 ` Linus Walleij
2020-07-17 7:16 Stephen Rothwell
2020-07-17 9:01 ` Hanks Chen
2020-07-17 11:37 ` Linus Walleij
2020-03-30 6:19 Stephen Rothwell
2020-02-25 1:21 Stephen Rothwell
2020-02-25 9:14 ` Marco Felsch
2019-08-21 6:16 Stephen Rothwell
2019-08-21 7:00 ` Linus Walleij
2016-12-06 22:27 Peter Rosin
2016-12-06 22:46 ` Stephen Rothwell
2016-12-06 23:05 ` Peter Rosin
2016-12-04 23:00 Stephen Rothwell
2016-12-06 21:31 ` Stephen Rothwell
2016-12-07 14:22 ` Linus Walleij
2016-05-12 4:14 Stephen Rothwell
2016-05-12 13:39 ` Linus Walleij
2015-12-21 4:58 Stephen Rothwell
2015-12-21 6:23 ` Pramod Kumar
2015-12-21 8:44 ` Linus Walleij
2015-12-18 3:45 Stephen Rothwell
2015-12-18 5:34 ` Pramod Kumar
2015-12-18 5:57 ` Stephen Rothwell
2015-12-18 6:12 ` Pramod Kumar
2015-12-18 17:05 ` Ray Jui
2015-09-25 3:34 Stephen Rothwell
2015-10-02 3:37 ` Stephen Rothwell
2015-10-05 7:38 ` Linus Walleij
2015-01-12 5:02 Stephen Rothwell
2015-01-12 7:25 ` Linus Walleij
2014-10-27 3:35 Stephen Rothwell
2014-05-30 6:08 Stephen Rothwell
2014-05-30 8:19 ` Linus Walleij
2014-02-11 3:56 Stephen Rothwell
2014-02-11 8:21 ` Linus Walleij
2013-12-10 3:02 Stephen Rothwell
2013-12-10 4:06 ` Stephen Rothwell
2013-12-10 8:50 ` Linus Walleij
2013-12-09 4:18 Stephen Rothwell
2013-09-20 3:27 Stephen Rothwell
2012-04-04 2:44 Stephen Rothwell
2012-04-04 3:43 ` Stephen Warren
2012-04-10 7:42 ` Linus Walleij
2012-04-10 15:12 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127204126.484d8f0a@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=chanho61.park@samsung$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox