Subject: Re: [PATCH] media: i2c: fix max9271 build dependencies

From: Mauro Carvalho Chehab <[email-masked]>
Date: Mon, 8 Feb 2021 14:11:02 +0100

Em Mon, 8 Feb 2021 12:41:42 +0100
Jacopo Mondi <[email-masked]> escreveu:

> > > If you do, instead:
> > >
> > >     if VIDEO_V4L2 && I2C
> > > 	config VIDEO_MAX9271_SERIALIZER
> > > 		tristate
> > >
> > > 	config VIDEO_RDACM20
> > > 		select VIDEO_MAX9271_SERIALIZER
> > > 		...
> > >
> > > 	config VIDEO_RDACM21
> > > 		select VIDEO_MAX9271_SERIALIZER
> > > 		...
> > >     endif
> > >
> > > Then you also won't need:
> > > 	depends on VIDEO_MAX9271_SERIALIZER || !VIDEO_MAX9271_SERIALIZER
> > >
> > > As select should do the right thing in this case, ensuring that MAX9271
> > > will be builtin either if RDACM20 or RDACM21 is builtin.  
> >
> > I also vote for usage of "select".
> >  
> 
> I would prefer that too, I was concerned about possible un-met
> dependencies, as Sakari pointed out, but the current situation is no
> better, as the only Kconfig symbols where those can be listed are the
> camera modules one.

Works for me. I'll make a patch for it.

Thanks,
Mauro