From: Sakari Ailus <sakari.ailus@iki•fi>
To: Jacopo Mondi <jacopo+renesas@jmondi•org>
Cc: Mauro Carvalho Chehab <mchehab@kernel•org>,
Laurent Pinchart <laurent.pinchart@ideasonboard•com>,
Sakari Ailus <sakari.ailus@linux•intel.com>,
linux-media@vger•kernel.org, linux-next@vger•kernel.org,
linux-renesas-soc@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>,
Nathan Chancellor <nathan@kernel•org>
Subject: Re: [PATCH] media: i2c: max9271: Add MODULE_* macros
Date: Wed, 10 Feb 2021 18:08:31 +0200 [thread overview]
Message-ID: <20210210160831.GC3@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20210210154908.1227203-1-jacopo+renesas@jmondi.org>
On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote:
> Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271
> a module") the max9271 library is built as a module but no
> MODULE_*() attributes were specified, causing a build error
> due to missing license information.
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o
>
> Fix this by adding MODULE attributes to the driver.
>
> Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module")
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Reported-by: Nathan Chancellor <nathan@kernel•org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi•org>
> ---
> drivers/media/i2c/max9271.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c
> index c247db569bab..c495582dcff6 100644
> --- a/drivers/media/i2c/max9271.c
> +++ b/drivers/media/i2c/max9271.c
> @@ -18,6 +18,7 @@
>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> +#include <linux/module.h>
>
> #include "max9271.h"
>
> @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest)
> return 0;
> }
> EXPORT_SYMBOL_GPL(max9271_set_translation);
> +
> +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer");
> +MODULE_AUTHOR("Jacopo Mondi");
> +MODULE_LICENSE("GPL v2");
Acked-by: Sakari Ailus <sakari.ailus@linux•intel.com>
--
Sakari Ailus
next prev parent reply other threads:[~2021-02-10 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 15:49 [PATCH] media: i2c: max9271: Add MODULE_* macros Jacopo Mondi
2021-02-10 16:08 ` Sakari Ailus [this message]
2021-02-10 16:15 ` Laurent Pinchart
2021-02-10 16:28 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210160831.GC3@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki$(echo .)fi \
--cc=jacopo+renesas@jmondi$(echo .)org \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=mchehab@kernel$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=sakari.ailus@linux$(echo .)intel.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox