Subject: Coverity: wiz_mode_select(): Uninitialized variables

From: coverity-bot <[email-masked]>
Date: Wed, 31 Mar 2021 14:57:34 -0700

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")

Coverity reported the following:

*** CID 1503592:  Uninitialized variables  (UNINIT)
/drivers/phy/ti/phy-j721e-wiz.c: 344 in wiz_mode_select()
338     	for (i = 0; i < num_lanes; i++) {
339     		if (wiz->lane_phy_type[i] == PHY_TYPE_DP)
340     			mode = LANE_MODE_GEN1;
341     		else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII)
342     			mode = LANE_MODE_GEN2;
343
vvv     CID 1503592:  Uninitialized variables  (UNINIT)
vvv     Using uninitialized value "mode" when calling "regmap_field_write".
344     		ret = regmap_field_write(wiz->p_standard_mode[i], mode);
345     		if (ret)
346     			return ret;
347     	}
348
349     	return 0;

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1503592 ("Uninitialized variables")
Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")

Thanks for your attention!

-- 
Coverity-bot