Subject: Coverity: parse_veto_list(): Resource leaks

From: coverity-bot <[email-masked]>
Date: Wed, 31 Mar 2021 14:58:15 -0700

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    788b6f45c1d2 ("cifsd: add server-side procedures for SMB3")

Coverity reported the following:

*** CID 1503590:  Resource leaks  (RESOURCE_LEAK)
/fs/cifsd/mgmt/share_config.c: 101 in parse_veto_list()
95     		p = kzalloc(sizeof(struct ksmbd_veto_pattern), GFP_KERNEL);
96     		if (!p)
97     			return -ENOMEM;
98
99     		sz = strlen(veto_list);
100     		if (!sz)
vvv     CID 1503590:  Resource leaks  (RESOURCE_LEAK)
vvv     Variable "p" going out of scope leaks the storage it points to.
101     			break;
102
103     		p->pattern = kstrdup(veto_list, GFP_KERNEL);
104     		if (!p->pattern) {
105     			ksmbd_free(p);
106     			return -ENOMEM;

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1503590 ("Resource leaks")
Fixes: 788b6f45c1d2 ("cifsd: add server-side procedures for SMB3")

Thanks for your attention!

-- 
Coverity-bot