Subject: Coverity: m_can_receive_skb(): Error handling issues

From: coverity-bot <[email-masked]>
Date: Wed, 31 Mar 2021 15:00:00 -0700

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context")

Coverity reported the following:

*** CID 1503583:  Error handling issues  (CHECKED_RETURN)
/drivers/net/can/m_can/m_can.c: 470 in m_can_receive_skb()
464     */
465     static void m_can_receive_skb(struct m_can_classdev *cdev,
466     			      struct sk_buff *skb,
467     			      u32 timestamp)
468     {
469     	if (cdev->is_peripheral)
vvv     CID 1503583:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "can_rx_offload_queue_sorted" without checking return value (as is done elsewhere 7 out of 8 times).
470     		can_rx_offload_queue_sorted(&cdev->offload, skb, timestamp);
471     	else
472     		netif_receive_skb(skb);
473     }
474
475     static void m_can_read_fifo(struct net_device *dev, u32 rxfs)

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1503583 ("Error handling issues")
Fixes: 1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context")

Thanks for your attention!

-- 
Coverity-bot